Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update forgeblocks, add subdomain to psl #1252

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Update forgeblocks, add subdomain to psl #1252

merged 2 commits into from
Mar 30, 2021

Conversation

roderickparr
Copy link
Contributor

@roderickparr roderickparr commented Mar 29, 2021

  • Description of Organization

  • Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration.

Description of Organization

Organization Website:

Reason for PSL Inclusion

DNS Verification via dig

make test

@roderickparr
Copy link
Contributor Author

I submitted all the prerequisites in the initial PR to add forgeblocks.com.

@dnsguru dnsguru changed the title Add tenant domain to psl Add forgeblocks domain to psl Mar 29, 2021
@dnsguru dnsguru self-assigned this Mar 29, 2021
@dnsguru dnsguru changed the title Add forgeblocks domain to psl Update forgeblocks, add subdomain to psl Mar 29, 2021
@dnsguru
Copy link
Member

dnsguru commented Mar 29, 2021

Updates #1238

@dnsguru
Copy link
Member

dnsguru commented Mar 29, 2021

Please give a rationale on this...
I see also #1251 - while this PR extends and updates the info submitted in the original #1238, please at least provide a rationale for this individual update - why is there a new domain being added. We want each PR to stand on their own without hunting/searching for the references

@roderickparr
Copy link
Contributor Author

The id.forgerock.io domain is our tenant domain. This is the domain where our customer tenants reside and we issue subdomains ie widgets.id.forgerock.io. Browsers should treat each subdomain of id.forgerock.io (and forgeblocks.com) as completely separate websites.

Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove trailing whitespace at EOL

@roderickparr
Copy link
Contributor Author

removed trailing whitespace

Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - extends #1238 ; same submitter = prior

@dnsguru dnsguru merged commit ee75a99 into publicsuffix:master Mar 30, 2021
@dnsguru
Copy link
Member

dnsguru commented Mar 30, 2021

Thanks @roderickparr and pardon the pedantia

@roderickparr
Copy link
Contributor Author

All good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants