Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add qnap entries to existing section (myqnapcloud.cn , mycloudnas.com, mynascloud.com) #1837

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

qnapnickchang
Copy link
Contributor

@qnapnickchang qnapnickchang commented Aug 28, 2023

add a new domain for our public dynamic dns service

Public Suffix List (PSL) Pull Request (PR) Template

Each PSL PR needs to have a description, rationale, indication of DNS validation and syntax checking, as well as a number of acknowledgements from the submitter. This template must be included with each PR, and the submitting party MUST provide responses to all of the elements in order to be considered.

Checklist of required steps

  • Description of Organization

  • Robust Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _PSL txt record in place in the respective zone(s) in the affected section

Submitter affirms the following:

  • We are listing any third-party limits that we seek to work around in our rationale such as those between IOS 14.5+ and Facebook (see Issue #1245 as a well-documented example)
  • This request was not submitted with the objective of working around other third-party limits
  • The Guidelines were carefully read and understood, and this request conforms
  • The submission follows the guidelines on formatting and sorting

For Private section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.

To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.

PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.

(Link: about propagation/expectations)

  • Yes, I understand. I could break my organization's website cookies etc. and the rollback timing, etc is acceptable. Proceed.

Description of Organization

Organization Website: https://www.qnap.com
QNAP System Inc. is a corporation that specializes in Network-attached storage (NAS) appliances.

Reason for PSL Inclusion

Hello, I'm engineer from qnap.com and we would like to add a new domain for our public dynamic dns service.
Number of users this request is being made to serve: 1,00k

DNS Verification via dig

dig +short TXT _psl.myqnapcloud.cn
"https://github.com/publicsuffix/list/pull/1837"
dig +short TXT _psl.mycloudnas.com
"https://github.com/publicsuffix/list/pull/1837"
dig +short TXT _psl.mynascloud.com
"https://github.com/publicsuffix/list/pull/1837"

Results of Syntax Checker (make test)

add a new domain for our public dynamic dns service
@dnsguru dnsguru changed the title Update public_suffix_list.dat add qnap entries to existing section (myqnapcloud.cn , mycloudnas.com, mynascloud.com) Sep 1, 2023
Copy link
Contributor

@simon-friedberger simon-friedberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the sorting. (The old entries are also wrong.) If you can, please add a non-personal e-mail.

@simon-friedberger simon-friedberger added ❌FAIL - FIX SORTING ⏬ https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important ❌FAIL - DOMAIN NOT 2Y+ *ALL* names in PRIVATE section MUST hold terms of 2 years or more registration from PR date #1109 labels Mar 7, 2024
@simon-friedberger
Copy link
Contributor

@qnapnickchang Any updates?

@simon-friedberger simon-friedberger added the 👻 about to timeout Submitter not responding for >30 Days label Apr 10, 2024
@qnapnickchang
Copy link
Contributor Author

Hi @simon-friedberger fix soring. please check again. thanks

@simon-friedberger simon-friedberger removed the 👻 about to timeout Submitter not responding for >30 Days label Apr 10, 2024
@simon-friedberger
Copy link
Contributor

simon-friedberger commented Apr 10, 2024

  • Expiration (Note: Must STAY >2y at all times)
    • mycloudnas.com expires 2027-07-19
    • mynascloud.com expires 2027-08-19
    • myqnapcloud.cn expires 2026-07-10
    • dev-myqnapcloud.com expires 2026-08-16
    • alpha-myqnapcloud.com expires 2027-02-23
    • myqnapcloud.com expires 2027-01-24
  • DNS _psl entries (Note: Must STAY in place)
    • mycloudnas.com
    • mynascloud.com
    • myqnapcloud.cn
    • dev-myqnapcloud.com
    • alpha-myqnapcloud.com
    • myqnapcloud.com
  • Tests pass
  • Sorting
  • Reasoning/Organization description

@qnapnickchang
Copy link
Contributor Author

Hi @simon-friedberger

  • domain renew. Please check again.
  • Fix soring

Thanks

@simon-friedberger simon-friedberger added ✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# ✔️Sorting Validated https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important r=simon-friedberger Marked as approved and ready to merge by @simon-friedberger and removed ❌FAIL - FIX SORTING ⏬ https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important ❌FAIL - DOMAIN NOT 2Y+ *ALL* names in PRIVATE section MUST hold terms of 2 years or more registration from PR date #1109 labels Apr 15, 2024
@@ -14138,8 +14138,11 @@ qcx.io

// QNAP System Inc : https://www.qnap.com
// Submitted by Nick Chang <nickchang@qnap.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use an address which isn't tied to a specific person.

@qnapnickchang
Copy link
Contributor Author

@simon-friedberger
Updated. Please check again.

Thanks

@simon-friedberger simon-friedberger merged commit 041f08f into publicsuffix:master Apr 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# r=simon-friedberger Marked as approved and ready to merge by @simon-friedberger ✔️Sorting Validated https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important
Projects
Status: Done or Won't
Development

Successfully merging this pull request may close these issues.

2 participants