Improvements in DNS TTL, platform ID and proxy authentication #78
Conversation
- Use TTL from DNS response, cache resolved addresses for that period - Identify Windows vs POSIX and C vs C++ (vs Qt) for reporting to the server - Detect authenticating proxy that works incorrectly, mostly the kind of broken proxy that keeps asking for the credentials over and over again, as-if we're not providing them.
Also, improve `windows-gcc` makefile (not quite completely, though).
core/pbhttp_digest.h
Outdated
| realm currently in use | ||
| */ | ||
| pbhtdig_EqualConsecutiveRealms, | ||
| /** atribute 'realm' is not found yet in 'authentication required' message header |
There was a problem hiding this comment.
Nitpick: Typo in comment, should be attribute
| el.end = p->http_reply + p->http_buf_len; | ||
| jpresult = pbjson_get_object_value(&el, "t", &found); | ||
| if (jonmpOK == jpresult) { | ||
| struct pbjson_elem titel; |
There was a problem hiding this comment.
Nitpick: Should this variable be title ?
There was a problem hiding this comment.
Actually, no, it's a short-form of "_ti_me _t_oken _el_ement". It's a kind of an inside joke, also, there's a small town called "Titel" in Serbia. :)
qt/pubnub_qt.cpp
Outdated
| static QString GetOsName() | ||
| { | ||
| #if defined(Q_OS_ANDROID) | ||
| return QLatin1String("android"); |
qt/pubnub_qt.cpp
Outdated
| #if defined(Q_OS_ANDROID) | ||
| return QLatin1String("android"); | ||
| #elif defined(Q_OS_BLACKBERRY) | ||
| return QLatin1String("blackberry"); |
qt/pubnub_qt.cpp
Outdated
| #elif defined(Q_OS_MACOS) | ||
| return QLatin1String("MacOS"); | ||
| #elif defined(Q_OS_TVOS) | ||
| return QLatin1String("Tvos"); |
There was a problem hiding this comment.
Nitpick: Casing -> tvOS
Per Apple's developer page: https://developer.apple.com/
qt/pubnub_qt.cpp
Outdated
| #elif defined(Q_OS_IOS) | ||
| return QLatin1String("iOS"); | ||
| #elif defined(Q_OS_MACOS) | ||
| return QLatin1String("MacOS"); |
There was a problem hiding this comment.
Nitpick: Casing -> macOS
Per Apple's developer page: https://developer.apple.com/
qt/pubnub_qt.cpp
Outdated
| #elif defined(Q_OS_TVOS) | ||
| return QLatin1String("Tvos"); | ||
| #elif defined(Q_OS_WATCHOS) | ||
| return QLatin1String("Watchos"); |
There was a problem hiding this comment.
Nitpick: Casing -> watchOS
Per Apple's developer page: https://developer.apple.com/
qt/pubnub_qt.cpp
Outdated
| #elif defined(Q_OS_WATCHOS) | ||
| return QLatin1String("Watchos"); | ||
| #elif defined(Q_OS_WINCE) | ||
| return QLatin1String("Wince"); |
There was a problem hiding this comment.
Nitpick: Perhaps we should call it Windows CE ?
Their docs have stopped shortening it: https://www.microsoft.com/en-us/download/details.aspx?id=14226
period
to the server
kind of broken proxy that keeps asking for the credentials
over and over again, as-if we're not providing them.