Signals support #83
Signals support #83
Conversation
Support for the Signals is added. Signals are like messages except that new signal on the channel pushes out (remvoes) the previous signal (there is no history). Signals also can't have metadata and compressing them is not supported. On the receiving side, if using subscribe V2, user can see if the received message is a signal or a (regular) message. This prompted completing the support for subscribe V2 in C++ & Qt. Other than that, some smaller code cleanups (removing warnings from various code checkers/analyzers).
|
Codacy complains about constructors with one argument that are not "explicit", but, we actually want them to be implicit. Unfortunately, there is no way to silence Codacy on this... |
| @@ -0,0 +1,160 @@ | |||
| /* -*- c-file-style:"stroustrup"; indent-tabs-mode: nil -*- */ | |||
core/pbcc_subscribe_v2.c
Outdated
| jpresult = pbjson_get_object_value(&el, "e", &found); | ||
| if (jonmpOK == jpresult) { | ||
| if (pbjson_elem_equals_string(&found, "1")) { | ||
| rslt.is_signal = true; |
There was a problem hiding this comment.
We will have more message types going forward. For example e=2 => ObjectsType and e=3 => MessageActionsType
Not sure if we should have a boolean for each type or just an enum of TYPES.
core/pubnub_internal_common.h
Outdated
| #define PUBNUB_USE_ADVANCED_HISTORY 0 | ||
| #endif | ||
|
|
||
| #if !defined(PUBNUB_USE_ENTITY_API) |
core/pubnub_netcore.c
Outdated
| #if PUBNUB_USE_ADVANCED_HISTORY | ||
| #include "core/pbcc_advanced_history.h" | ||
| #endif | ||
| #if PUBNUB_USE_ENTITY_API |
core/pubnub_netcore.c
Outdated
| #else | ||
| , dont_parse /* PBTT_MESSAGE_COUNTS */ | ||
| #endif | ||
| #if PUBNUB_USE_ENTITY_API |
core/pubnub_subscribe_v2_message.h
Outdated
| /** The message metadata, as published */ | ||
| struct pubnub_char_mem_block metadata; | ||
| /** is the message a signal(, or published) */ | ||
| bool is_signal; |
There was a problem hiding this comment.
This might be better as an enum of types, we will have the following types: publish, signal, objects, message_actions and probably more in the future
cpp/posix.mk
Outdated
| USE_ADVANCED_HISTORY = 1 | ||
| endif | ||
|
|
||
| ifndef USE_ENTITY_API |
cpp/posix_openssl.mk
Outdated
| USE_ADVANCED_HISTORY = 1 | ||
| endif | ||
|
|
||
| ifndef USE_ENTITY_API |
openssl/posix.mk
Outdated
| USE_ADVANCED_HISTORY = 1 | ||
| endif | ||
|
|
||
| ifndef USE_ENTITY_API |
openssl/pubnub_config.h
Outdated
| #define PUBNUB_USE_ADVANCED_HISTORY 1 | ||
| #endif | ||
|
|
||
| #if !defined(PUBNUB_USE_ENTITY_API) |
posix/posix.mk
Outdated
| USE_ADVANCED_HISTORY = 1 | ||
| endif | ||
|
|
||
| ifndef USE_ENTITY_API |
posix/pubnub_config.h
Outdated
| #define PUBNUB_USE_ADVANCED_HISTORY 1 | ||
| #endif | ||
|
|
||
| #if !defined(PUBNUB_USE_ENTITY_API) |
qt/pubnub_config.h
Outdated
| #define PUBNUB_USE_ADVANCED_HISTORY 1 | ||
| #endif | ||
|
|
||
| #if !defined(PUBNUB_USE_ENTITY_API) |
windows/pubnub_config.h
Outdated
| collection of rest API features that enables "CRUD"(Create, Read, Update and Delete) | ||
| on two new pubnub objects: User and Space, as well as manipulating connections | ||
| between them. */ | ||
| #define PUBNUB_USE_ENTITY_API 1 |
|
Also Codacy requires fixes |
As explained in a comment, Codacy is simply wrong here, it complains about some constructors not being |
Can we just modify the rule that Codacy is using or add a "disable" comment to that section for Additionally what are your thoughts about message type as an enum vs a bunch of flags per type? |
* Entity API -> Objects API * pubnub_signal() does not a HTTP verb/method support. It just GETs it. * Prepare to support other message types (than publish and signal) * Add pubnub_stop() for graceful shutdown when using the callback interface
Working on making a Codacy configuration, but it's poorly documented, so it will take some time to figure out. |
Support for the Signals is added. Signals are like messages except
that new signal on the channel pushes out (remvoes) the previous
signal (there is no history). Signals also can't have metadata and
compressing them is not supported.
On the receiving side, if using subscribe V2, user can see if the
received message is a signal or a (regular) message. This prompted
completing the support for subscribe V2 in C++ & Qt.
Other than that, some smaller code cleanups (removing warnings
from various code checkers/analyzers).