Skip to content

Conversation

vveljko
Copy link
Contributor

@vveljko vveljko commented Nov 17, 2019

User can now enable sending of heartbeat messages "in the background"
on the given context. These heartbeat messages will actually be sent
via a different context, so, won't prevent the user from sending using
her context anyway she sees fit. Heartbeat is sent according to the
latest subscribe() - if the user does a new subscribe() with new
channel/group, the heartbeats will be updated and sent accordingly.

User can now enable sending of heartbeat messages "in the background"
on the given context. These heartbeat messages will actually be sent
via a different context, so, won't prevent the user from sending using
her context anyway she sees fit. Heartbeat is sent according to the
latest subscribe() - if the user does a new subscribe() with new
channel/group, the heartbeats will be updated and sent accordingly.
@PubNubBot
Copy link

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 2
           

See the complete overview on Codacy

@vveljko vveljko marked this pull request as ready for review November 17, 2019 13:13
@vveljko
Copy link
Contributor Author

vveljko commented Nov 17, 2019

The "errors" reported by Codacy are weird issues that CppCheck has with multiple #ifdef configurations. They are hard to fix (teach CppCheck about your precompiler "configurations") and one simply learns to ignore them by default.

@vveljko vveljko requested a review from davidnub November 17, 2019 13:14
@davidnub
Copy link

The "errors" reported by Codacy are weird issues that CppCheck has with multiple #ifdef configurations. They are hard to fix (teach CppCheck about your precompiler "configurations") and one simply learns to ignore them by default.

Can we just ignore them via compiler flag in Codacy?

Copy link

@davidnub davidnub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks! 👍

@vveljko vveljko merged commit 0a2830e into master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants