Fix entity usage issue #460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue because of which in new flow `heartbeat` request not cancelled properly when issued in burst. fix(cbor): fix issue with resource name as integer Fix issue because resource names, which consist only of integers, have been decoded as Unicode characters. fix(subscription): fix issue with unsubscription on entity with a similar name Fix issue because the entity that has been created with `-pnpres` suffix has been removed from subscription loop during unsubscribe from entity with presence listening capability. feat(shared-worker): start backup heartbeat timer Launch a backup heartbeat timer per registered PubNub instance in SharedWorker context to protect against browsers throttling of background (hidden) tabs. refactor(logger): use explicit names of classes instead of constructor Use string names of classes for locations instead of dynamic access to constructor names because it affect how logs looks like after minification.
parfeon
added
priority: medium
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
mohitpubnub
reviewed
Jun 30, 2025
| return string + String.fromCharCode(byte); | ||
| }, ''); | ||
| } else if (isNumber(key) || (keyIsString && !isNaN(Number(key)))) { | ||
| stringifiedKey = String.fromCharCode(isNumber(key) ? key : parseInt(key, 10)); |
mohitpubnub
approved these changes
Jun 30, 2025
| @@ -149,7 +149,7 @@ export class EventEngine { | |||
| } | |||
|
|
|||
| unsubscribeAll(isOffline: boolean = false): void { | |||
| const channelGroups = this.getSubscribedChannels(); | |||
| const channelGroups = this.getSubscribedChannelGroups(); | |||
| @@ -33,8 +33,8 @@ export const HeartbeatFailedState = new State<HeartbeatFailedStateContext, Event | |||
|
|
|||
| HeartbeatFailedState.on(joined.type, (context, event) => | |||
| HeartbeatingState.with({ | |||
| channels: [...context.channels, ...event.payload.channels], | |||
| groups: [...context.groups, ...event.payload.groups], | |||
| channels: [...context.channels, ...event.payload.channels.filter((channel) => !context.channels.includes(channel))], | |||
There was a problem hiding this comment.
good to have this
this filtering was missing in presence event engine
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
techwritermat and
kazydek
as code owners
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(subscription-flow): fix
heartbeatcancellation failureFix issue because of which in new flow
heartbeatrequest not cancelled properly when issued inburst.
fix(cbor): fix issue with resource name as integer
Fix issue because resource names, which consist only of integers, have been decoded as Unicode characters.
fix(subscription): fix issue with unsubscription on entity with a similar name
Fix issue because the entity that has been created with
-pnpressuffix has been removedfrom subscription loop during unsubscribe from entity with presence listening capability.
feat(shared-worker): start backup heartbeat timer
Launch a backup heartbeat timer per registered PubNub instance in SharedWorker context to protect
against browsers throttling of background (hidden) tabs.
refactor(logger): use explicit names of classes instead of constructor
Use string names of classes for locations instead of dynamic access to constructor names because it affect how logs looks like after minification.