Add missing implementation for ChannelGroup entity (Apple and JS platforms) #355
Conversation
jguz-pubnub
requested review from
kleewho,
marcin-cebo and
parfeon
as code owners
jguz-pubnub
changed the title
| override fun subscription(options: SubscriptionOptions): Subscription { | ||
| // TODO: Add support for handling SubscriptionOptions | ||
| return SubscriptionImpl(objCSubscription = KMPSubscription(entity = channelGroup)) | ||
| val presenceOptions = options.allOptions.filterIsInstance<ReceivePresenceEventsImpl>() |
There was a problem hiding this comment.
I see there are tests for a channel/channel group entity in this repository:
However, by default, they are only executed on the jvm target. We would need to replicate the same effort here as was done in the KMP chat project
| override val name: String | ||
| get() = jsChannelGroup.name | ||
|
|
||
| override fun subscription(options: SubscriptionOptions): Subscription { // todo use options |
There was a problem hiding this comment.
Is todo comment up to date ?
There was a problem hiding this comment.
I think so, because there's no support for FilterImpl options
There was a problem hiding this comment.
I see. I was misled because I saw options being used in code below. Maybe todo comment could be modified with more precise info?
jguz-pubnub
changed the title
| override val name: String | ||
| get() = jsChannelGroup.name | ||
|
|
||
| override fun subscription(options: SubscriptionOptions): Subscription { // todo use options |
There was a problem hiding this comment.
I see. I was misled because I saw options being used in code below. Maybe todo comment could be modified with more precise info?
jguz-pubnub
changed the title
|
@pubnub-release-bot release kotlin as v10.5.3 |
|
🛑 Build failed. Please check release build for details 🛑 |
3 participants
fix: Internal fixes