Internal change - enabled EE for JS target in KMP tests #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcin-cebo
requested review from
kleewho,
jguz-pubnub,
parfeon and
jakub-grzesiowski
as code owners
jguz-pubnub
reviewed
Jul 28, 2025
| fun test_disconnect() = runTest(timeout = 30.seconds) { | ||
| val channelName = "myChannel" | ||
|
|
||
| val statusListener = createStatusListener(pubnub) { _, status -> |
There was a problem hiding this comment.
What is the purpose of the empty statusListener?
There was a problem hiding this comment.
Good point. Current shape of the test is not intuitive.
nextStatus() is responsible for getting latest status.
I will fix that.
jguz-pubnub
approved these changes
Jul 28, 2025
marcin-cebo
force-pushed
the
mc/enableEE_kmp_js_tests
branch
from
1360ce0 to
b6d3b4d
Compare
|
@pubnub-release-bot release kotlin as v10.5.6 |
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Internal change - enabled EE for JS target in KMP tests