Add explicit pug-walk dependency #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I'll merge this within the next week. |
Closed
|
👍 ran into this, would be good to have. |
Akkuma
added a commit
to Akkuma/pug-loader
that referenced
this pull request
Aug 17, 2016
The difference between pugjs#49 and this fix is that it doesn't rely upon making `pug-walk` a dependency of the project. In my opinion, if you're going to make that a dependency, you should make all of those required files dependencies. This approach works for both npm 2 and npm 3 without making any of those packages explicit dependencies.
TimothyGu
pushed a commit
that referenced
this pull request
Aug 23, 2016
Signed-off-by: Timothy Gu <timothygu99@gmail.com>
|
Merged in 86f6d98. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added explicit pug-walk dependency, as it was not found before.