Add support for jstransformers, deprecate Transformers #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
| // these marker transformers haven't made sense in a long time | ||
| css: 'verbatim', | ||
| js: 'verbatim', | ||
| }; |
There was a problem hiding this comment.
Might be able to use the transform.inputFormats values for these alternatives.
There was a problem hiding this comment.
We could, but I think in this case it's probably better to get people to specify the exact canonical name of that transform. It prevents any potential ambiguity and makes loading the relevant transformer much simpler (otherwise we have to look for all possible transformers in the parent path and load all of them just in case one of them matches).
ForbesLindesay
added a commit
that referenced
this pull request
May 18, 2015
Add support for jstransformers, deprecate Transformers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So many people have done such fantastic work to make this possible. This will make it really easy to independently publish/update/fix each separate filter.