Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making sure the correct fonts are used for li elements #483

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

escowles
Copy link
Member

@escowles escowles commented Jan 8, 2019

Fixes #425

There is probably a bigger SCSS issue here, but given that we're planning to revamp the design of the front page, and probably the fonts and usage of pul-assets in the near term, I thought a working fix was good enough.

@escowles escowles added the review label Jan 8, 2019
@escowles
Copy link
Member Author

escowles commented Jan 8, 2019

When the correct fonts are used, the diacritics are displayed correctly in Firefox:

screen shot 2019-01-08 at 4 22 22 pm

@tpendragon tpendragon merged commit 00e5d86 into master Jan 8, 2019
@tpendragon tpendragon deleted the firefox-font-fix branch January 8, 2019 21:47
@tpendragon tpendragon removed the review label Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems exist with the diacritics for certain item metadata views
2 participants