Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix js build for pulldown #544

Closed
wants to merge 6 commits into from
Closed

fix js build for pulldown #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0e6a35b
revert to original tag
mccalluc Oct 21, 2022
b6147ef
change to vite
mccalluc Oct 21, 2022
6132889
revert to javascript_pack_tag
mccalluc Oct 21, 2022
bbcb49a
just javascript_tag
mccalluc Oct 21, 2022
e8fabe6
Try javascript_include_tag
mccalluc Oct 21, 2022
0d93384
remove skip_pipeline / add to manifest / CAS blocking localhost?
mccalluc Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/assets/config/manifest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
//= link_tree ../images
//= link_directory ../stylesheets .css
//= link jquery-ui-triggeredAutocomplete.js
0 ...vendor/jquery-ui-triggeredAutocomplete.js → ...cripts/jquery-ui-triggeredAutocomplete.js
View file
Open in desktop
File renamed without changes.
2 changes: 0 additions & 2 deletions app/javascript/entrypoints/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ const channels = import.meta.globEager('../channels/*.js')
import Rails from "@rails/ujs"
import Turbolinks from "turbolinks"
import ActiveStorage from "@rails/activestorage"
// Provides @mention functionality in textboxes (adds to jQuery UI autocomplete)
import "./vendor/jquery-ui-triggeredAutocomplete"

if (typeof(window._rails_loaded) == "undefined" || window._rails_loaded == null || !window._rails_loaded) {
Rails.start()
Expand Down
6 changes: 5 additions & 1 deletion app/views/layouts/application.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,11 @@
<%= render partial: 'shared/footer' %>
</body>

<!-- Provides @mention functionality in textboxes (adds to jQuery UI autocomplete)-->
<!--
Provides @mention functionality in textboxes (adds to jQuery UI autocomplete);
Doesn't precompile well when moved to application.js.
-->
<%= javascript_include_tag 'jquery-ui-triggeredAutocomplete' %>

<%= vite_javascript_tag 'file_upload', 'data-turbolinks-track': 'reload' %>
<%= vite_javascript_tag 'orcid', 'data-turbolinks-track': 'reload' %>
Expand Down