Skip to content
This repository has been archived by the owner on May 14, 2022. It is now read-only.

Allow drag for generating structure. #246

Merged
merged 1 commit into from
Dec 16, 2015
Merged

Conversation

tpendragon
Copy link
Contributor

No description provided.

@escowles
Copy link
Member

👍 -- the dragging works for me, and having an obvious drag anchor helps too.

@tpendragon
Copy link
Contributor Author

The only weird thing is creating, IE, chapter 2 means you have to drag two-levels deep to create the node, and then drag that created node back a level.

No solution for that though, maybe that's just how it is.

@jpstroop
Copy link
Member

(From Slack conversation:)

  • I wonder if bringing back the button you had near the top to create an arbitrary range might help mitigate your "chapter 2" problem?
  • probably better to add the new node at the top?
  • shift+click doesn't seem to work
  • should be able to collapse any structure I've created

@tpendragon
Copy link
Contributor Author

So I added the requested features. Right now the way the plugin works is as you drag an object down, it'll expand collapsed items so that you can sort it into the tree. Which makes sense, but maybe we should disable that feature? It makes the "button to add a section" more troublesome than helpful, I think.

I also wonder if maybe there should be a "section above me" button.

@tpendragon
Copy link
Contributor Author

Deploying this to staging to try out.

@jpstroop
Copy link
Member

jpstroop commented Dec 15, 2015 via email

@jpstroop
Copy link
Member

Was too anxious 😉.

I think we're barking up the right tree.

How about cleaning up the boxes:

  • add thumbnails
  • get rid of bullets (I assume I'm not the only one seeing them? See image below)
  • move the expand/collapse arrow to the right side (wouldn't want to accidentally click the 'x')
  • make the x seem more severe - maybe even a red bootstrap warning label?
  • make the form box a little bigger

And add a notification when the save is successful / fails, and then call this good for Friday?

screen shot 2015-12-15 at 11 01 15 am

@tpendragon
Copy link
Contributor Author

@jpstroop "Form box"?

@tpendragon
Copy link
Contributor Author

@jpstroop Maybe the "x" should be on the right side, by itself? Seems like having to reach for it would be important.

@jpstroop
Copy link
Member

Sorry. The field where the user adds the label for the new range. Some of them get really long. E.g. search for Glinka in the PUDL.

@jpstroop
Copy link
Member

Maybe the "x" should be on the right side, by itself? Seems like having to reach for it would be important.

We can try whatever, but I also found the expand/collapse button difficult to find and thought that might make more sense to the far right.

@tpendragon
Copy link
Contributor Author

@jpstroop Pushed up some styling changes, take a look at staging?

@jpstroop
Copy link
Member

👍 I'm cool w/ the expand/collapse arrows now too. I think thumbnails will give us a good first pass for Friday and you should make this into a PR once they're added.

@tpendragon
Copy link
Contributor Author

I'm curious about how to do thumbnails - I'm concerned about size issues if I add a .panel-body. Any thoughts?

@tpendragon
Copy link
Contributor Author

@jpstroop Added thumbnails and pushed to staging - take a look?

@tpendragon
Copy link
Contributor Author

@jpstroop says 👍, so squashed and ready for review.

escowles added a commit that referenced this pull request Dec 16, 2015
@escowles escowles merged commit b69cb75 into master Dec 16, 2015
@escowles escowles deleted the new_structure_editor branch December 16, 2015 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants