Upgrade to node 12, just getting a new yarn.lock (#825)

* Upgrade to node 12, just getting a new yarn.lock fixes #821 * Use `lts/ebrium` instead of specific node version This is because ansible grabs the latest release of the major version, so we might fall behind in tests if we provision the server
pulibrary · Aug 17, 2020 · 6e00f03 · 6e00f03
1 parent 498fe85
commit 6e00f03
Show file tree

Hide file tree

Showing 3 changed files with 3,042 additions and 2,513 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -22,15 +22,15 @@ jobs:
         name: Restore Yarn cache
         key: pomegranate-yarn-{{ checksum "yarn.lock" }}-1
       - run:
-          name: Install node@8.17.0 (need right version for `yarn`)
+          name: Install node@lts/erbium (need right version for `yarn`)
           command: |
             set +e
             touch $BASH_ENV
             curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.5/install.sh | bash
             echo 'export NVM_DIR="$HOME/.nvm"' >> $BASH_ENV
             echo '[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"' >> $BASH_ENV
-            echo 'nvm install v8.17.0' >> $BASH_ENV
-            echo 'nvm alias default v8.17.0' >> $BASH_ENV
+            echo 'nvm install lts/erbium' >> $BASH_ENV
+            echo 'nvm alias default lts/erbium' >> $BASH_ENV
       - run:
           name: Check current version of node
           command: node -v
@@ -92,15 +92,15 @@ jobs:
       # Wait for DB
       - run: dockerize -wait tcp://localhost:5432 -timeout 1m
       - run:
-          name: Install node@8.17.0 (need right version for `yarn`)
+          name: Install node@lts/erbium (need right version for `yarn`)
           command: |
             set +e
             touch $BASH_ENV
             curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.5/install.sh | bash
             echo 'export NVM_DIR="$HOME/.nvm"' >> $BASH_ENV
             echo '[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"' >> $BASH_ENV
-            echo 'nvm install v8.17.0' >> $BASH_ENV
-            echo 'nvm alias default v8.17.0' >> $BASH_ENV
+            echo 'nvm install lts/erbium' >> $BASH_ENV
+            echo 'nvm alias default lts/erbium' >> $BASH_ENV
       - run:
           name: Check current version of node
           command: node -v

diff --git a/.tool-versions b/.tool-versions
@@ -1,2 +1,2 @@
 ruby 2.6.5
-nodejs 8.16.1
+nodejs 12.18.3