Fix: select highest constrained version #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous behavior may choose the newest commit instead of the highest version, which may not be intended behavior. This way the highest compatible version tag is picked.
andreaskurth
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resolving version dependencies, bender will pick the newest version among compatible version numbers instead of the highest acceptable version number. While normally a newer compatible commit will have a higher version number, this may not always be the case.
This fix makes use of sorted Sets to ensure the highest version is picked.
As an example to test, udma_i2c exhibits this behavior when checking out version 1, as it uses
v1.0.1instead ofv1.0.3.