Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tokio, update futures, rewrite for async/await #94

Merged
merged 3 commits into from
Aug 5, 2022
Merged

Conversation

micprog
Copy link
Member

@micprog micprog commented Jul 28, 2022

To update further dependencies, the codebase was slightly modified to comply with async/await, updating tokio and futures dependencies. Most of the structures were attempted to be kept, but some were modified away from .and_then structures for simpler implementation. Due to time constraints, throttling was not fully implemented yet. My own testing did not uncover any issues, also on larger (PULPissimo) repositories, but improved throttling implementation may be necessary.

Copy link
Contributor

@andreaskurth andreaskurth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this big piece of work, @micprog!

I could not review this in detail due to time constraints, but if you have tested the changes with sufficiently complex use cases, I suggest to proceed with merging.

.map(move |_| git),
),
)
// TODO MICHAERO: May need throttle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to create an issue on GitHub to track this and the other throttle

@micprog micprog merged commit f82ef0e into master Aug 5, 2022
@micprog micprog mentioned this pull request Aug 5, 2022
@micprog micprog mentioned this pull request Apr 6, 2023
@micprog micprog deleted the tokio branch July 21, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants