Update tokio, update futures, rewrite for async/await #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micprog
force-pushed
the
tokio
branch
3 times, most recently
from
d34610e
to
809b9ce
Compare
andreaskurth
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
Thanks for this big piece of work, @micprog!
I could not review this in detail due to time constraints, but if you have tested the changes with sufficiently complex use cases, I suggest to proceed with merging.
| .map(move |_| git), | ||
| ), | ||
| ) | ||
| // TODO MICHAERO: May need throttle |
There was a problem hiding this comment.
Suggest to create an issue on GitHub to track this and the other throttle
Open
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To update further dependencies, the codebase was slightly modified to comply with
async/await, updating tokio and futures dependencies. Most of the structures were attempted to be kept, but some were modified away from.and_thenstructures for simpler implementation. Due to time constraints, throttling was not fully implemented yet. My own testing did not uncover any issues, also on larger (PULPissimo) repositories, but improved throttling implementation may be necessary.