Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

occamy: Fix const cache mismatches #250

Merged
merged 1 commit into from
Sep 15, 2021
Merged

occamy: Fix const cache mismatches #250

merged 1 commit into from
Sep 15, 2021

Conversation

zarubaf
Copy link
Contributor

@zarubaf zarubaf commented Sep 15, 2021

Okay, here is my untested try to fix the mismatches. I've also added an assertion so that this doesn't happen again. Probably also wise to add the check to the other cluster ports.

@zarubaf zarubaf requested a review from niwis as a code owner September 15, 2021 11:46
@paulsc96
Copy link
Collaborator

Thanks! I will do some checks to make sure this resolves our issues.

@paulsc96 paulsc96 mentioned this pull request Sep 15, 2021
Closed
paulsc96
paulsc96 approved these changes Sep 15, 2021
View reviewed changes
Copy link
Collaborator

@paulsc96 paulsc96 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work in simulation :) No more errors or unexpected requests at the quadrant interfaces, and I can de-isolate an individual quadrant and gate the fetching of Snitch clusters accordingly. Good to go for me 👍

@zarubaf zarubaf merged commit 7b4b563 into master Sep 15, 2021
@zarubaf zarubaf deleted the fix/const-cache-mismatch branch September 15, 2021 20:40
colluca pushed a commit to pulp-platform/occamy that referenced this pull request Aug 19, 2023
@zarubaf
occamy: Fix const cache mismatches (pulp-platform/snitch#250)
38b6894
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulsc96 paulsc96 paulsc96 approved these changes

@niwis niwis Awaiting requested review from niwis niwis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zarubaf @paulsc96