Attempt to guess the MIME type of content served with xsendfile. #2396
Conversation
| @@ -68,7 +69,13 @@ def x_send(path): | |||
| :rtype: django.http.HttpResponse | |||
| """ | |||
| if os.access(path, os.R_OK): | |||
| reply = HttpResponse() | |||
| content_type = mimetypes.guess_type(path) | |||
There was a problem hiding this comment.
We could use a library like libmagic to determine the file type (which will be much more accurate), but I was hesitant to introduce a new dependency. The downside to this method is that if the file suffix is wrong/missing (like the listing files which are text of some variety) the 'application/octet-stream' is used.
There was a problem hiding this comment.
FWIW, there is a Python binding to libmagic that seems to "come with" Fedora last I checked. I'm not sure about ELs though. Also, it's not documented, and I spent quite a lot of time trying to figure out how to use its API.
Oh, and there are no less than three Python libraries that are bindings to libmagic that share the same name but do not have the same API. If we depend on one of them, it will be difficult to express which one we need in our setup.py which could be bad if we ever want to work in Debian, which by the way uses a different one than Fedora uses.
This is mostly for the benefit of browsers, since the default MIME type Django uses is text/html which causes the browser to attempt to render RPMs and such instead of downloading them. closes pulp#1627
jeremycline
force-pushed
the
set-content-type-xsendfile
branch
from
3170d35
to
2b1b2ae
Compare
Attempt to guess the MIME type of content served with xsendfile.
This is mostly for the benefit of browsers, since the default MIME
type Django uses is text/html which causes the browser to attempt to
render RPMs and such instead of downloading them.
closes #1627