-
Notifications
You must be signed in to change notification settings - Fork 168
Fixes #3883 - Log to console by default #3567
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3567 +/- ##
======================================
Coverage 58.2% 58.2%
======================================
Files 59 59
Lines 2467 2467
======================================
Hits 1436 1436
Misses 1031 1031
Continue to review full report at Codecov.
|
@@ -68,7 +68,7 @@ | |||
# formatter: simple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines also need to be removed. They show the defaults.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed this was showing users how to set the formatter just like it shows how to configure a syslog handler. I think it would be useful to the discussion to express what the intent for examples in server.yaml are as that would help guide the change needed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The convention so far is that commented sections are the place for the user to see the exact defaults. Examples are good though, what about moving it to the docs in the logging section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes requested in server.yaml
I believe I have made the requested changes. |
This looks good to me. Thanks @ehelms ! 👍 |
No description provided.