Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
/ pulp Public archive

Fixes #3883 - Log to console by default #3567

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Conversation

ehelms
Copy link
Contributor

@ehelms ehelms commented Jul 25, 2018

No description provided.

@codecov
Copy link

codecov bot commented Jul 25, 2018

Codecov Report

Merging #3567 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3567   +/-   ##
======================================
  Coverage    58.2%   58.2%           
======================================
  Files          59      59           
  Lines        2467    2467           
======================================
  Hits         1436    1436           
  Misses       1031    1031
Impacted Files Coverage Δ
pulpcore/pulpcore/app/settings.py 98.38% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c76efb...e61cf39. Read the comment docs.

@@ -68,7 +68,7 @@
# formatter: simple
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines also need to be removed. They show the defaults.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed this was showing users how to set the formatter just like it shows how to configure a syslog handler. I think it would be useful to the discussion to express what the intent for examples in server.yaml are as that would help guide the change needed here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The convention so far is that commented sections are the place for the user to see the exact defaults. Examples are good though, what about moving it to the docs in the logging section?

Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes requested in server.yaml

@dralley dralley added the 3.0 label Jul 26, 2018
@ehelms
Copy link
Contributor Author

ehelms commented Jul 31, 2018

I believe I have made the requested changes.

@bmbouter
Copy link
Member

bmbouter commented Aug 1, 2018

This looks good to me. Thanks @ehelms ! 👍

@bmbouter bmbouter merged commit 24aca7c into pulp:master Aug 1, 2018
bmbouter pushed a commit to bmbouter/pulp that referenced this pull request Sep 1, 2018
bmbouter pushed a commit to bmbouter/pulp that referenced this pull request Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants