-
Notifications
You must be signed in to change notification settings - Fork 168
Adds description of the date filters format #3572
Conversation
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #3572 +/- ##
==========================================
+ Coverage 58.2% 58.32% +0.11%
==========================================
Files 59 59
Lines 2467 2474 +7
==========================================
+ Hits 1436 1443 +7
Misses 1031 1031
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the commit message with both the URL to the issue and the 'closes #' or 'fixes #'. You can see an example at the end of this section[0] of docs.
[0] https://docs.pulpproject.org/dev-guide/contributing/branching.html#commit-messages
Understand, thanks, fixed. |
@daviddavis @dkliban Wouldn't it be better to add support for this upstream? django-filters already has |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve. Though I do encourage you to see about contributing this feature to upstream project.
Actually, I think it would be a good idea to try to submit this upstream. 👍 from me. |
Ok, I opened PR on django-filters - carltongibson/django-filter#961. |
I'm going to wait a couple more days for a response on carltongibson/django-filter#961 and if there's none, I'll merge this. |
No response from upstream. Merging. |
closes #3825
https://pulp.plan.io/issues/3825