Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
/ pulp Public archive

Adds description of the date filters format #3572

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Adds description of the date filters format #3572

merged 1 commit into from
Aug 21, 2018

Conversation

vdusek
Copy link

@vdusek vdusek commented Jul 31, 2018

@pulpbot
Copy link
Member

pulpbot commented Jul 31, 2018

Can one of the admins verify this patch?

@codecov
Copy link

codecov bot commented Jul 31, 2018

Codecov Report

Merging #3572 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3572      +/-   ##
==========================================
+ Coverage    58.2%   58.32%   +0.11%     
==========================================
  Files          59       59              
  Lines        2467     2474       +7     
==========================================
+ Hits         1436     1443       +7     
  Misses       1031     1031
Impacted Files Coverage Δ
pulpcore/pulpcore/app/viewsets/repository.py 70.8% <100%> (+0.18%) ⬆️
pulpcore/pulpcore/app/viewsets/custom_filters.py 59.25% <100%> (+11.64%) ⬆️
pulpcore/pulpcore/app/viewsets/task.py 76.56% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c76efb...32776fb. Read the comment docs.

Copy link
Member

@dkliban dkliban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the commit message with both the URL to the issue and the 'closes #' or 'fixes #'. You can see an example at the end of this section[0] of docs.

[0] https://docs.pulpproject.org/dev-guide/contributing/branching.html#commit-messages

@vdusek
Copy link
Author

vdusek commented Aug 1, 2018

Understand, thanks, fixed.

@dralley
Copy link
Contributor

dralley commented Aug 7, 2018

@daviddavis @dkliban Wouldn't it be better to add support for this upstream?

django-filters already has help_text for some fields, just not all of them.

Copy link
Member

@dkliban dkliban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve. Though I do encourage you to see about contributing this feature to upstream project.

@daviddavis
Copy link
Contributor

Actually, I think it would be a good idea to try to submit this upstream. 👍 from me.

@vdusek
Copy link
Author

vdusek commented Aug 9, 2018

Ok, I opened PR on django-filters - carltongibson/django-filter#961.

@daviddavis
Copy link
Contributor

I'm going to wait a couple more days for a response on carltongibson/django-filter#961 and if there's none, I'll merge this.

@dralley dralley added the 3.0 label Aug 17, 2018
@daviddavis
Copy link
Contributor

No response from upstream. Merging.

@daviddavis daviddavis merged commit 49d3979 into pulp:master Aug 21, 2018
@vdusek vdusek deleted the issue_3825 branch September 11, 2018 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants