Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
/ pulp Public archive

Fix pulpcore README on pypi #3819

Merged
merged 1 commit into from
Jan 4, 2019
Merged

Conversation

CodeHeeler
Copy link

The badges weren't displaying properly.
Markdown was not being interpreted correctly and now is.

fixes #4277
https://pulp.plan.io/issues/4277

Pull Requests

Please be sure you have read our documentation regarding contributing
here:
https://docs.pulpproject.org/en/3.0/nightly/contributing/index.html

There you can read a Contribution Checklist and learn more about
appropriate branches and rebasing among other things.

Once you are ready to create a pull request:

  • For properly formatting commit messages, please see the
    documentation here:
    https://docs.pulpproject.org/en/3.0/nightly/contributing/git.html#commit-message
  • Once you have created your pull request, please add a link to
    your pull request into the notes/comments for the relevant bug in the
    issue tracker and change the status to POST.
  • Continuous integration tests will be automatically triggered
    by your pull request. You can see the status of these tests on the
    page for your pull request. If there are failures, please try to
    fix them and update your pull request.

Thank you so much for contributing to Pulp!

The badges weren't displaying properly.
Markdown was not being interpreted correctly and now is.

fixes #4277
https://pulp.plan.io/issues/4277
@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #3819 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3819   +/-   ##
=======================================
  Coverage   55.68%   55.68%           
=======================================
  Files          64       64           
  Lines        2796     2796           
=======================================
  Hits         1557     1557           
  Misses       1239     1239

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 202bfdd...9863f65. Read the comment docs.

Copy link
Contributor

@daviddavis daviddavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daviddavis daviddavis merged commit 5876f37 into pulp:master Jan 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants