Remove the doc and coverage checks from run-tests.py. #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc_check and coverage checking are new in Pulp's master branch, but we want 1.0.0 of the plugins to work against Pulp 2.5 ideally, or at least 2.6.0. This commit removes the doc_check and coverage check from run-tests. Also, 2.5 did not list its dependencies in its setup.py, so this adds them to the .travis.yml file. This change must not be propagated to master.
|
LGTM |
|
I just confirmed that this was merged to master with the ours strategy, as it should have been. I believe this will allow the 1.0-* branches to have this fix (which is necessary), but also that merging forward will not introduce this change to master (which is undesirable). Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc_check and coverage checking are new in Pulp's master branch, but we want 1.0.0 of the
plugins to work against Pulp 2.5 ideally, or at least 2.6.0. This commit removes the doc_check
and coverage check from run-tests.
Also, 2.5 did not list its dependencies in its setup.py, so this adds them to the .travis.yml
file.
This change must not be propagated to master.