Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change publish layout to Packages/[a-z]/* #1016

Merged
merged 1 commit into from
Jan 16, 2017
Merged

Change publish layout to Packages/[a-z]/* #1016

merged 1 commit into from
Jan 16, 2017

Conversation

fdobrovolny
Copy link
Contributor

@mention-bot
Copy link

@BrnoPCmaniak, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mhrivnak, @ipanova and @pcreech to be potential reviewers.

@fdobrovolny fdobrovolny mentioned this pull request Jan 16, 2017
Closed
23 tasks
@fdobrovolny fdobrovolny force-pushed the publish_dirs branch 2 times, most recently from ba6cd56 to 8a2e418 Compare January 16, 2017 14:08
goosemania
goosemania reviewed Jan 16, 2017
View reviewed changes
docs/user-guide/release-notes/2.11.x.rst
* Added support for publishing ISO repositories to custom relative paths.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the changes here? There should be none for 2.11 release notes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goosemania there was a newline at the end by editor fixed now

@dkliban
Copy link
Member

dkliban commented Jan 16, 2017

ok test

@dkliban
Copy link
Member

dkliban commented Jan 16, 2017

The unit test failure for Fedora 23 can be ignored. We have stopped building F23 packages for 2.12 release. I don't expect the unit tests to pass because the dependencies needed to run the tests are not available for F23.

dkliban
dkliban approved these changes Jan 16, 2017
View reviewed changes
Copy link
Member

@dkliban dkliban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR in conjunction with pulp/pulp#2913. I verified that when I publish with the yum distributor and the rpm rsync distributor, the same directory structure is created by both distributors.

goosemania
goosemania reviewed Jan 16, 2017
View reviewed changes
plugins/pulp_rpm/plugins/migrations/0037_rpm_primary_repodata_new_location.py

def migrate(*args, **kwargs):
"""Migrate RPMs and SRPMs location to new format "Packages/[a-z]/.*".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only one newline is needed and "Migrate ..." should start from a new line.

goosemania
goosemania approved these changes Jan 16, 2017
View reviewed changes
Copy link
Member

@goosemania goosemania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrnoPCmaniak , thanks a lot for this work!
I tested publish, incremental publish, migration, RPMs/DRPMs/SRPMs. All looks good to me. 👍

@fdobrovolny fdobrovolny merged commit 7842645 into pulp:master Jan 16, 2017
@fdobrovolny fdobrovolny deleted the publish_dirs branch January 16, 2017 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkliban dkliban dkliban approved these changes

@goosemania goosemania goosemania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fdobrovolny @mention-bot @dkliban @goosemania