-
-
Notifications
You must be signed in to change notification settings - Fork 50
Sidebar active tabs #159
Sidebar active tabs #159
Conversation
QA Requirements
|
Currently browsers do not keep up with new sidebar sizing on 107, and removed shortcuts still exist in the background. With changes coming with Sidebar Active Tabs, the QA checks will need an update too. In draft for now due to this. |
Removed shortcuts now get removed after restart of the browser. This is the case with every other loaded tab as well. Persistence is only kept when keepTabsActive is set to false. |
Welcome options for sidebar will be available on next PR. |
This reverts commit 3e8797c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not be merged if it requires a browser restart to work correctly. Either:
a) Remove the preference
b) Add a preference observer and fix whatever ends up being broken that requires a browser restart
src/browser/locales/en-US/browser/preferences/preferences-ftl.patch
Outdated
Show resolved
Hide resolved
Changed to draft until changes made, I am not too sure why it was not on draft already after last review. |
This comment was marked as resolved.
This comment was marked as resolved.
Preference now relies on observer, reloading the sidebar and removing any left over content and changes have been updated to sync with alpha. |
Also, you forgot to run `./mach lint --fix [file]`, so the formatting has changed to be correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea sorry, forgot to lint.
Fixes #146 Implementing Sidebar Background Active Tabs