Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Sidebar active tabs #159

Merged
merged 26 commits into from
Jan 2, 2023
Merged

Sidebar active tabs #159

merged 26 commits into from
Jan 2, 2023

Conversation

PressJump
Copy link
Member

Fixes #146 Implementing Sidebar Background Active Tabs

@PressJump PressJump linked an issue Nov 19, 2022 that may be closed by this pull request
@PressJump PressJump marked this pull request as draft November 19, 2022 07:33
@PressJump
Copy link
Member Author

PressJump commented Nov 19, 2022

QA Requirements

  • Sidebar

    • The sidebar exists
    • The settings and addons button are visible down the bottom
    • The bookmarks, history and synced tabs icons are in the sidebar
    • The sidebar can be resized properly
    • An installed extension will appear in the sidebar
    • Sidebar-Tabs is Loaded and has a button visible down the bottom
    • Sidebar-Tabs can add a sidebar item to the sidebar
    • Sidebar-Tabs can remove a sidebar item to the sidebar
    • The sidebar keeps tabs active while closed when the preference pulse.sidebar.keeptabsactive.enabled is set to true
    • The sidebar overwrites tabs when the preference pulse.sidebar.keeptabsactive.enabled is set to false
  • Extensions

    • Tabliss is loading correctly
    • Tabliss does not have the webextention symbol in the title bar
    • uBlock origin is loading correctly
    • QRCode generator is loading correctly
  • About dialog

    • The new about dialog is present
    • The dialog has not significantly changed
  • Pocket

    • Pocket is not present in the browser
  • Preferences

    • All tabs in preferences open
    • The "More from {Vendor}" option is not present
    • The sidebar preferences are present and work as expected
  • Welcome experience

    • The import button opens the import wizard
    • The theme picker is present and works as expected
    • The search engine picker is present and works as expected
  • Pulse theme

    • The tabs appear to be consistent
  • Mozilla theme

    • The sidebar tabs are correct
  • Useragent

    • The user agent is reporting as Mozilla Firefox

@PressJump
Copy link
Member Author

Currently browsers do not keep up with new sidebar sizing on 107, and removed shortcuts still exist in the background. With changes coming with Sidebar Active Tabs, the QA checks will need an update too. In draft for now due to this.

@PressJump
Copy link
Member Author

Removed shortcuts now get removed after restart of the browser. This is the case with every other loaded tab as well. Persistence is only kept when keepTabsActive is set to false.

@PressJump
Copy link
Member Author

Welcome options for sidebar will be available on next PR.

@PressJump PressJump self-assigned this Nov 23, 2022
@PressJump PressJump requested a review from trickypr November 23, 2022 04:06
@PressJump PressJump marked this pull request as ready for review November 23, 2022 04:13
Copy link
Member

@trickypr trickypr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not be merged if it requires a browser restart to work correctly. Either:
a) Remove the preference
b) Add a preference observer and fix whatever ends up being broken that requires a browser restart

@PressJump PressJump marked this pull request as draft December 12, 2022 11:31
@PressJump
Copy link
Member Author

Changed to draft until changes made, I am not too sure why it was not on draft already after last review.

@PressJump

This comment was marked as resolved.

@PressJump
Copy link
Member Author

Preference now relies on observer, reloading the sidebar and removing any left over content and changes have been updated to sync with alpha.

@PressJump PressJump marked this pull request as ready for review January 1, 2023 07:39
@PressJump PressJump requested a review from trickypr January 1, 2023 07:39
PressJump and others added 2 commits January 1, 2023 18:58
Also, you forgot to run `./mach lint --fix [file]`, so the formatting
has changed to be correct.
Copy link
Member Author

@PressJump PressJump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea sorry, forgot to lint.

@PressJump PressJump requested a review from trickypr January 1, 2023 23:11
@PressJump PressJump merged commit 19f4663 into alpha Jan 2, 2023
@PressJump PressJump deleted the sidebar-active-tabs branch January 2, 2023 00:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Websites should remain active even when a tab is closed
2 participants