Replace Turnstyle with a custom script #4410
Conversation
cnunciato
force-pushed
the
cnunciato/replace-turnstyle
branch
3 times, most recently
from
6708eeb to
cca5e5c
Compare
cnunciato
force-pushed
the
cnunciato/replace-turnstyle
branch
from
cca5e5c to
294e51b
Compare
|
Your site preview for commit 4f3556c is ready! 🎉 http://pulumi-docs-origin-pr-4410-4f3556c2.s3-website.us-west-2.amazonaws.com. |
![pulumi[bot]](https://avatars.githubusercontent.com/in/15540?s=60&v=4){kind=small}
There was a problem hiding this comment.
🍹 The Update (preview) for stack pulumi/www.pulumi.com/production was successful.
Resource Changes
Name Type Operation
~ cdn aws:cloudfront/distribution:Distribution update
~ www.pulumi.com aws:route53/record:Record update
* origin-bucket-policy aws:s3/bucketPolicy:BucketPolicy replaced
|
Your site preview for commit 21b5ebc is ready! 🎉 http://pulumi-docs-origin-pr-4410-21b5ebc0.s3-website.us-west-2.amazonaws.com. |
There was a problem hiding this comment.
🍹 The Update (preview) for stack pulumi/www.pulumi.com/production was successful.
Resource Changes
Name Type Operation
* origin-bucket-policy aws:s3/bucketPolicy:BucketPolicy replaced
~ cdn aws:cloudfront/distribution:Distribution update
~ www.pulumi.com aws:route53/record:Record update
|
Your site preview for commit cca5e5c is ready! 🎉 http://pulumi-docs-origin-pr-4410-cca5e5cd.s3-website.us-west-2.amazonaws.com. |
There was a problem hiding this comment.
🍹 The Update (preview) for stack pulumi/www.pulumi.com/production was successful.
Resource Changes
Name Type Operation
* origin-bucket-policy aws:s3/bucketPolicy:BucketPolicy replaced
~ cdn aws:cloudfront/distribution:Distribution update
~ www.pulumi.com aws:route53/record:Record update
|
Your site preview for commit 6708eeb is ready! 🎉 http://pulumi-docs-origin-pr-4410-6708eeba.s3-website.us-west-2.amazonaws.com. |
There was a problem hiding this comment.
🍹 The Update (preview) for stack pulumi/www.pulumi.com/production was successful.
Resource Changes
Name Type Operation
* origin-bucket-policy aws:s3/bucketPolicy:BucketPolicy replaced
~ cdn aws:cloudfront/distribution:Distribution update
~ www.pulumi.com aws:route53/record:Record update
|
Your site preview for commit 294e51b is ready! 🎉 http://pulumi-docs-origin-pr-4410-294e51b8.s3-website.us-west-2.amazonaws.com. |
There was a problem hiding this comment.
🍹 The Update (preview) for stack pulumi/www.pulumi.com/production was successful.
Resource Changes
Name Type Operation
* origin-bucket-policy aws:s3/bucketPolicy:BucketPolicy replaced
~ cdn aws:cloudfront/distribution:Distribution update
~ www.pulumi.com aws:route53/record:Record update
cnunciato
force-pushed
the
cnunciato/replace-turnstyle
branch
from
294e51b to
38618e8
Compare
cnunciato
force-pushed
the
cnunciato/replace-turnstyle
branch
from
38618e8 to
3334e0d
Compare
|
Your site preview for commit 38618e8 is ready! 🎉 http://pulumi-docs-origin-pr-4410-38618e8d.s3-website.us-west-2.amazonaws.com. |
There was a problem hiding this comment.
🍹 The Update (preview) for stack pulumi/www.pulumi.com/production was successful.
Resource Changes
Name Type Operation
* origin-bucket-policy aws:s3/bucketPolicy:BucketPolicy replaced
~ cdn aws:cloudfront/distribution:Distribution update
~ www.pulumi.com aws:route53/record:Record update
|
Your site preview for commit 3334e0d is ready! 🎉 http://pulumi-docs-origin-pr-4410-3334e0de.s3-website.us-west-2.amazonaws.com. |
There was a problem hiding this comment.
🍹 The Update (preview) for stack pulumi/www.pulumi.com/production was successful.
Resource Changes
Name Type Operation
* origin-bucket-policy aws:s3/bucketPolicy:BucketPolicy replaced
~ cdn aws:cloudfront/distribution:Distribution update
~ www.pulumi.com aws:route53/record:Record update
| } | ||
| } | ||
|
|
||
| waitForInProgressRuns(); |
There was a problem hiding this comment.
What do you think of adding a .then(...).catch(...) here? That way we can log when the waiting has completed and also catch any errors that could occur in the script.
There was a problem hiding this comment.
Ah totally, we could to that -- but in this case, if the script fails, I want to fail the whole build (as that would mean something's wrong -- workflow not defined, various things we expect to "just be there"), so I'm deliberately not catching errors so they cause Node to exit non-zero and downstream jobs to be skipped.
|
Site previews for this pull request have been removed. ✨ |
This change replaces Turnstyle with a simple script that does essentially the same thing, but logs a bit more and gives us additional control and debuggability. The inline comments explain how it works, but the gist is that it waits for any currently running workflow of the same type on the same branch to complete before exiting (allowing the workflow to continue). Applies only to the default branch, as before.