Support http server by deferring to aws express lib. #584
Conversation
| // the problem. | ||
| return context => { | ||
| context.log("Error occurred creating server: " + err.message + "\n" + err.stack); | ||
| context.done(); |
There was a problem hiding this comment.
note: these logs go into the Function's log stream (similar to cloudwatch). It is not returned to the caller (i.e. a 3rd part) of this http endpoint..
|
Is it worth separating this out into it's own module (even just it's own file in this repo for now) that is independent of the rest of I could imagine either upstreaming this or creating/sharing a |
Yes. I think so. I'll open a bug to track that. That said, it's not high on my priority list. :) |
|
@lukehoban Are you ok with this PR? |
api/httpServer.ts
Outdated
| @@ -15,6 +15,8 @@ | |||
| import * as pulumi from "@pulumi/pulumi"; | |||
| import * as http from "http"; | |||
|
|
|||
| export type RequestListenerFactory = () => (req: http.IncomingMessage, res: http.ServerResponse) => void; | |||
There was a problem hiding this comment.
Perhaps a comment here, maybe even with a simple example implementation? This is really key to understanding the API here.
There was a problem hiding this comment.
Does RequestListener come from Nodejs or Express api docs or dts files? Would love to align on naming if there is an established name.
There was a problem hiding this comment.
It comes from Nodejs. They call it "requestListener" as the argument to http.createServer. I'll add a link to the docs here.
| headers: Record<string, string>; | ||
|
|
||
| // Currently unused. We may need to handle this to support binary data properly. | ||
| // isBase64Encoded?: boolean; |
There was a problem hiding this comment.
Any reason not to include this in the type, even if not yet used?
There was a problem hiding this comment.
No huge reason... I just felt it was good to call out that we hadn't explicitly added support for it.
The azure-specific library we were using was having several problems that i found i couldn't effectively solve/workaround. For example, serving static files would just crash. The AWS library we are using works quite well on everything i've thrown at it so far. So, as a real solution, i just made our Azure impl sit on top of hte AWS library. This did require some marshalling to/from the azure and aws types. But this marshalling was trivial. On a good note, it should mean uniform behavior of http server on AWS/Azure, which is definitely desirable.