Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cluster): Add cluster tagging option #262

Closed
wants to merge 1 commit into from

Conversation

naineel
Copy link
Contributor

@naineel naineel commented Oct 4, 2019

Fixes #261

Copy link
Contributor

@metral metral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

nodejs/eks/cluster.ts Outdated Show resolved Hide resolved
nodejs/eks/package.json Show resolved Hide resolved
nodejs/eks/package.json Outdated Show resolved Hide resolved
nodejs/eks/package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@metral metral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits to tweak but overall LGTM.

@metral
Copy link
Contributor

metral commented Oct 9, 2019

This PR is failing during a make test_all locally in a couple of places below.

I haven't looked closely enough but it may be the use of "@pulumi/aws": "^1.5.0" in the eks package.json that is causing mismatches with what the tests use for @pulumi/awsx:latest.

cc @CyrusNajmabadi @lukehoban

@naineel it may be worth it on your end to test changes as our CI only currently does full test runs for Pulumi staff members: https://github.com/pulumi/pulumi-eks/blob/master/CONTRIBUTING.md#running-integration-tests

[ xamples/tests/replace-secgroup ] Diagnostics:
[ xamples/tests/replace-secgroup ]   pulumi:pulumi:Stack (test-replace-secgroup-p-it-argon-replace-se-f5655fe4):
[ xamples/tests/replace-secgroup ]     debug: Registering resource: t=pulumi:pulumi:Stack, name=test-replace-secgroup-p-it-argon-replace-se-f5655fe4, custom=false
[ xamples/tests/replace-secgroup ]     debug: RegisterResource RPC prepared: t=pulumi:pulumi:Stack, name=test-replace-secgroup-p-it-argon-replace-se-f5655fe4
[ xamples/tests/replace-secgroup ]     debug: RegisterResource RPC finished: resource:test-replace-secgroup-p-it-argon-replace-se-f5655fe4[pulumi:pulumi:Stack]; err: null, resp: urn:pulumi:p-it-argon-replace-se-f5655fe4::test-replace-secgroup::pulumi:pulumi:Stack::test-replace-secgroup-p-it-argon-replace-se-f5655fe4,,,,
[ xamples/tests/replace-secgroup ]     debug: Running program '/tmp/p-it-argon-replace-se-f5655fe4-012574600' in pwd '/tmp/p-it-argon-replace-se-f5655fe4-012574600' w/ args:
[ xamples/tests/replace-secgroup ]     debug: RegisterResourceOutputs RPC prepared: urn=urn:pulumi:p-it-argon-replace-se-f5655fe4::test-replace-secgroup::pulumi:pulumi:Stack::test-replace-secgroup-p-it-argon-replace-se-f5655fe4
[ xamples/tests/replace-secgroup ]     error: Running program '/tmp/p-it-argon-replace-se-f5655fe4-012574600' failed with an unhandled exception:
[ xamples/tests/replace-secgroup ]     TSError: ⨯ Unable to compile TypeScript:
[ xamples/tests/replace-secgroup ]     index.ts(31,4): error TS2345: Argument of type 'Cluster' is not assignable to parameter of type 'ComponentResource'.
[ xamples/tests/replace-secgroup ]       Property 'registerOutputs' is protected but type 'ComponentResource' is not a class derived from 'ComponentResource'.
[ xamples/tests/replace-secgroup ]
[ xamples/tests/replace-secgroup ]         at createTSError (/tmp/p-it-argon-replace-se-f5655fe4-012574600/node_modules/ts-node/src/index.ts:261:12)
[ xamples/tests/replace-secgroup ]         at getOutput (/tmp/p-it-argon-replace-se-f5655fe4-012574600/node_modules/ts-node/src/index.ts:367:40)
[ xamples/tests/replace-secgroup ]         at Object.compile (/tmp/p-it-argon-replace-se-f5655fe4-012574600/node_modules/ts-node/src/index.ts:558:11)
[ xamples/tests/replace-secgroup ]         at Module.m._compile (/tmp/p-it-argon-replace-se-f5655fe4-012574600/node_modules/ts-node/src/index.ts:439:43)
[ xamples/tests/replace-secgroup ]         at Module._extensions..js (internal/modules/cjs/loader.js:700:10)
[ xamples/tests/replace-secgroup ]         at Object.require.extensions.(anonymous function) [as .ts] (/tmp/p-it-argon-replace-se-f5655fe4-012574600/node_modules/ts-node/src/index.ts:442:12)
[ xamples/tests/replace-secgroup ]         at Module.load (internal/modules/cjs/loader.js:599:32)
[ xamples/tests/replace-secgroup ]         at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
[ xamples/tests/replace-secgroup ]         at Function.Module._load (internal/modules/cjs/loader.js:530:3)
[ xamples/tests/replace-secgroup ]         at Module.require (internal/modules/cjs/loader.js:637:17)
[ xamples/tests/replace-secgroup ]     debug: RegisterResourceOutputs RPC finished: urn=urn:pulumi:p-it-argon-replace-se-f5655fe4::test-replace-secgroup::pulumi:pulumi:Stack::test-replace-secgroup-p-it-argon-replace-se-f5655fe4; err: null, resp:

and

[ i-eks/nodejs/eks/examples/tags ] Diagnostics:
[ i-eks/nodejs/eks/examples/tags ]   pulumi:pulumi:Stack (example-tags-p-it-argon-tags-6ae0f9c6):
[ i-eks/nodejs/eks/examples/tags ]     debug: Registering resource: t=pulumi:pulumi:Stack, name=example-tags-p-it-argon-tags-6ae0f9c6, custom=false
[ i-eks/nodejs/eks/examples/tags ]     debug: RegisterResource RPC prepared: t=pulumi:pulumi:Stack, name=example-tags-p-it-argon-tags-6ae0f9c6
[ i-eks/nodejs/eks/examples/tags ]     debug: RegisterResource RPC finished: resource:example-tags-p-it-argon-tags-6ae0f9c6[pulumi:pulumi:Stack]; err: null, resp: urn:pulumi:p-it-argon-tags-6ae0f9c6::example-tags::pulumi:pulumi:Stack::example-tags-p-it-argon-tags-6ae0f9c6,,,,
[ i-eks/nodejs/eks/examples/tags ]     debug: Running program '/tmp/p-it-argon-tags-6ae0f9c6-815330767' in pwd '/tmp/p-it-argon-tags-6ae0f9c6-815330767' w/ args:
[ i-eks/nodejs/eks/examples/tags ]     debug: RegisterResourceOutputs RPC prepared: urn=urn:pulumi:p-it-argon-tags-6ae0f9c6::example-tags::pulumi:pulumi:Stack::example-tags-p-it-argon-tags-6ae0f9c6
[ i-eks/nodejs/eks/examples/tags ]     error: Running program '/tmp/p-it-argon-tags-6ae0f9c6-815330767' failed with an unhandled exception:
[ i-eks/nodejs/eks/examples/tags ]     TSError: ⨯ Unable to compile TypeScript:
[ i-eks/nodejs/eks/examples/tags ]     index.ts(17,5): error TS2345: Argument of type '{ instanceType: "t2.medium"; desiredCapacity: number; minSize: number; maxSize: number; tags: { "project": string; "org": string; }; clusterSecurityGroupTags: { "myClusterSecurityGroupTag1": string; }; nodeSecurityGroupTags: { ...; }; clusterTags: { ...; }; deployDashboard: fa
lse; }' is not assignable to parameter of type 'ClusterOptions'.
[ i-eks/nodejs/eks/examples/tags ]       Object literal may only specify known properties, and 'clusterTags' does not exist in type 'ClusterOptions'.
[ i-eks/nodejs/eks/examples/tags ]     index.ts(37,5): error TS2345: Argument of type '{ skipDefaultNodeGroup: true; deployDashboard: false; instanceRole: Role; tags: { "project": string; "org": string; }; clusterSecurityGroupTags: { "myClusterSecurityGroupTag2": string; }; nodeSecurityGroupTags: { ...; }; clusterTags: { ...; }; }' is not assignable to parameter
 of type 'ClusterOptions'.
[ i-eks/nodejs/eks/examples/tags ]       Object literal may only specify known properties, and 'clusterTags' does not exist in type 'ClusterOptions'.
[ i-eks/nodejs/eks/examples/tags ]     index.ts(72,60): error TS7006: Parameter 'clusterName' implicitly has an 'any' type.

@metral
Copy link
Contributor

metral commented Jan 6, 2020

Replaced and closed in #269

@metral metral closed this Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Cluster tagging
2 participants