-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cluster): Add cluster tagging option #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nits to tweak but overall LGTM.
This PR is failing during a I haven't looked closely enough but it may be the use of @naineel it may be worth it on your end to test changes as our CI only currently does full test runs for Pulumi staff members: https://github.com/pulumi/pulumi-eks/blob/master/CONTRIBUTING.md#running-integration-tests
and
|
Replaced and closed in #269 |
Fixes #261