New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stringify `managedZoneId` #2034

Merged

iwahbe merged 3 commits into master from iwahbe/1036/stringify-managed-zone-id

May 30, 2024

Member

iwahbe commented May 29, 2024

Fixes #1036

iwahbe added 2 commits

May 28, 2024 18:06


          Mark managedZoneId as a string

d2a0db2

Fixes #1036


          make build_sdks

0f5b2b2

iwahbe self-assigned this

github-actions bot commented May 29, 2024 •

edited

Loading

Does the PR have any schema changes?

Found 2 breaking changes:

Resources

🟡 "gcp:dns/managedZone:ManagedZone": properties: "managedZoneId" type changed from "integer" to "string"

Types

🟡 "gcp:dns/getManagedZonesManagedZone:getManagedZonesManagedZone": properties: "managedZoneId" type changed from "integer" to "string"
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

iwahbe requested review from t0yv0, guineveresaenger and VenelinMartinov

May 29, 2024 01:18

iwahbe changed the title ~~Sringify managedZoneId~~ Stringify managedZoneId

VenelinMartinov approved these changes

View reviewed changes

Contributor

VenelinMartinov left a comment

looks good, we should make sure to call out the breaking change in the release notes

iwahbe force-pushed the iwahbe/1036/stringify-managed-zone-id branch 2 times, most recently from 50da882 to 461cc85 Compare

May 29, 2024 20:25

iwahbe enabled auto-merge (squash)

May 29, 2024 20:50

iwahbe mentioned this pull request

Upgrade terraform-provider-google-beta to v5.31.1 #2035

Closed

t0yv0 reviewed

View reviewed changes

provider/resources.go Show resolved Hide resolved

t0yv0 self-requested a review

May 30, 2024 15:19

t0yv0 approved these changes

View reviewed changes

iwahbe force-pushed the iwahbe/1036/stringify-managed-zone-id branch from 461cc85 to d1e70d9 Compare

May 30, 2024 18:06


          Add test

72b3b10

iwahbe force-pushed the iwahbe/1036/stringify-managed-zone-id branch from d1e70d9 to 72b3b10 Compare

May 30, 2024 20:00

iwahbe merged commit 9152da0 into master

17 checks passed

iwahbe deleted the iwahbe/1036/stringify-managed-zone-id branch

May 30, 2024 21:31

trunk-io bot referenced this pull request in ride-app/payments-service


          fix(deps): update dependency @pulumi/gcp to v7.25.0 (#1681)

473ca7d

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@pulumi/gcp](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-gcp)) | [`7.24.0` -> `7.25.0`](https://renovatebot.com/diffs/npm/@pulumi%2fgcp/7.24.0/7.25.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@pulumi%2fgcp/7.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@pulumi%2fgcp/7.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@pulumi%2fgcp/7.24.0/7.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@pulumi%2fgcp/7.24.0/7.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>pulumi/pulumi-gcp (@&#8203;pulumi/gcp)</summary>

### [`v7.25.0`](https://togithub.com/pulumi/pulumi-gcp/releases/tag/v7.25.0)

[Compare Source](https://togithub.com/pulumi/pulumi-gcp/compare/v7.24.0...v7.25.0)

#### Breaking changes:

\[Breaking][https://github.com/pulumi/pulumi-gcp/pull/2034](https://togithub.com/pulumi/pulumi-gcp/pull/2034)4: We have changed the type of `gcp:dns/managedZone:ManagedZone.managedZoneId` and `gcp:dns/getManagedZonesManagedZone:getManagedZonesManagedZone.managedZoneId` from an integer to a string. This is necessary to round trip the 64bit zone ID in all languages.

To migrate:
If you consume `managedZoneId` as a number, you will need to insert string to int64 parsing.
If you consume `mangadZoneId` as a string, you can simply remove your number to string conversion.

#### What's Changed

-   Update GitHub Actions workflows. by [@&#8203;pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2039](https://togithub.com/pulumi/pulumi-gcp/pull/2039)
-   Bump converter version by [@&#8203;VenelinMartinov](https://togithub.com/VenelinMartinov) in [https://github.com/pulumi/pulumi-gcp/pull/2037](https://togithub.com/pulumi/pulumi-gcp/pull/2037)
-   Stringify `managedZoneId` by [@&#8203;iwahbe](https://togithub.com/iwahbe) in [https://github.com/pulumi/pulumi-gcp/pull/2034](https://togithub.com/pulumi/pulumi-gcp/pull/2034)
-   Update GitHub Actions workflows. by [@&#8203;pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2041](https://togithub.com/pulumi/pulumi-gcp/pull/2041)
-   Upgrade terraform-provider-google-beta to v5.31.1 by [@&#8203;VenelinMartinov](https://togithub.com/VenelinMartinov) in [https://github.com/pulumi/pulumi-gcp/pull/2043](https://togithub.com/pulumi/pulumi-gcp/pull/2043)

**Full Changelog**: pulumi/pulumi-gcp@v7.24.0...v7.25.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ride-app/payments-service).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

trunk-io bot referenced this pull request in ride-app/user-service


          fix(deps): update dependency @pulumi/gcp to v7.25.0 (#981)

57e9410

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@pulumi/gcp](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-gcp)) | [`7.24.0` -> `7.25.0`](https://renovatebot.com/diffs/npm/@pulumi%2fgcp/7.24.0/7.25.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@pulumi%2fgcp/7.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@pulumi%2fgcp/7.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@pulumi%2fgcp/7.24.0/7.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@pulumi%2fgcp/7.24.0/7.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>pulumi/pulumi-gcp (@&#8203;pulumi/gcp)</summary>

### [`v7.25.0`](https://togithub.com/pulumi/pulumi-gcp/releases/tag/v7.25.0)

[Compare Source](https://togithub.com/pulumi/pulumi-gcp/compare/v7.24.0...v7.25.0)

#### Breaking changes:

\[Breaking][https://github.com/pulumi/pulumi-gcp/pull/2034](https://togithub.com/pulumi/pulumi-gcp/pull/2034)4: We have changed the type of `gcp:dns/managedZone:ManagedZone.managedZoneId` and `gcp:dns/getManagedZonesManagedZone:getManagedZonesManagedZone.managedZoneId` from an integer to a string. This is necessary to round trip the 64bit zone ID in all languages.

To migrate:
If you consume `managedZoneId` as a number, you will need to insert string to int64 parsing.
If you consume `mangadZoneId` as a string, you can simply remove your number to string conversion.

#### What's Changed

-   Update GitHub Actions workflows. by [@&#8203;pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2039](https://togithub.com/pulumi/pulumi-gcp/pull/2039)
-   Bump converter version by [@&#8203;VenelinMartinov](https://togithub.com/VenelinMartinov) in [https://github.com/pulumi/pulumi-gcp/pull/2037](https://togithub.com/pulumi/pulumi-gcp/pull/2037)
-   Stringify `managedZoneId` by [@&#8203;iwahbe](https://togithub.com/iwahbe) in [https://github.com/pulumi/pulumi-gcp/pull/2034](https://togithub.com/pulumi/pulumi-gcp/pull/2034)
-   Update GitHub Actions workflows. by [@&#8203;pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2041](https://togithub.com/pulumi/pulumi-gcp/pull/2041)
-   Upgrade terraform-provider-google-beta to v5.31.1 by [@&#8203;VenelinMartinov](https://togithub.com/VenelinMartinov) in [https://github.com/pulumi/pulumi-gcp/pull/2043](https://togithub.com/pulumi/pulumi-gcp/pull/2043)

**Full Changelog**: pulumi/pulumi-gcp@v7.24.0...v7.25.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ride-app/user-service).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet