Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix firestore field permadiff by enabling PRC #2182

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

VenelinMartinov
Copy link
Contributor

Fixes #2166

Enabled PRC for firestore field which prevents a permadiff in the indexConfig parameter.

@VenelinMartinov VenelinMartinov added the needs-release/patch When a PR with this label merges, it initiates a release of vX.Y.Z+1 label Jul 11, 2024
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link
Contributor

@flostadler flostadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VenelinMartinov VenelinMartinov enabled auto-merge (squash) July 11, 2024 12:36
@VenelinMartinov VenelinMartinov merged commit 28ead1e into master Jul 11, 2024
23 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/fix_firestore_field_permadiff branch July 11, 2024 12:52
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v7.31.0.

trunk-io bot referenced this pull request in ride-app/platform Jul 16, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@pulumi/gcp](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-gcp)) | [`7.29.0` -> `7.31.0`](https://renovatebot.com/diffs/npm/@pulumi%2fgcp/7.29.0/7.31.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@pulumi%2fgcp/7.31.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@pulumi%2fgcp/7.31.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@pulumi%2fgcp/7.29.0/7.31.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@pulumi%2fgcp/7.29.0/7.31.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>pulumi/pulumi-gcp (@&#8203;pulumi/gcp)</summary>

### [`v7.31.0`](https://togithub.com/pulumi/pulumi-gcp/releases/tag/v7.31.0)

[Compare Source](https://togithub.com/pulumi/pulumi-gcp/compare/v7.30.2...v7.31.0)

##### Does the PR have any schema changes?

Looking good! No breaking changes found.

##### New resources:

-   `securesourcemanager/repository.Repository`
-   `securesourcemanager/repositoryIamBinding.RepositoryIamBinding`
-   `securesourcemanager/repositoryIamMember.RepositoryIamMember`
-   `securesourcemanager/repositoryIamPolicy.RepositoryIamPolicy`
-   `securitycenter/v2OrganizationNotificationConfig.V2OrganizationNotificationConfig`

##### New functions:

-   `kms/getCryptoKeys.getCryptoKeys`
-   `kms/getKeyRings.getKeyRings`
-   `securesourcemanager/getRepositoryIamPolicy.getRepositoryIamPolicy`

##### What's Changed

-   Fix firestore field permadiff by enabling PRC by [@&#8203;VenelinMartinov](https://togithub.com/VenelinMartinov) in [https://github.com/pulumi/pulumi-gcp/pull/2182](https://togithub.com/pulumi/pulumi-gcp/pull/2182)
-   Fix firestore database resource leak by [@&#8203;VenelinMartinov](https://togithub.com/VenelinMartinov) in [https://github.com/pulumi/pulumi-gcp/pull/2187](https://togithub.com/pulumi/pulumi-gcp/pull/2187)
-   Fix test flake by [@&#8203;VenelinMartinov](https://togithub.com/VenelinMartinov) in [https://github.com/pulumi/pulumi-gcp/pull/2188](https://togithub.com/pulumi/pulumi-gcp/pull/2188)
-   Update GitHub Actions workflows. by [@&#8203;pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2192](https://togithub.com/pulumi/pulumi-gcp/pull/2192)
-   Update GitHub Actions workflows. by [@&#8203;pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2194](https://togithub.com/pulumi/pulumi-gcp/pull/2194)
-   Upgrade terraform-provider-google-beta to v5.37.0 by [@&#8203;VenelinMartinov](https://togithub.com/VenelinMartinov) in [https://github.com/pulumi/pulumi-gcp/pull/2193](https://togithub.com/pulumi/pulumi-gcp/pull/2193)

**Full Changelog**: pulumi/pulumi-gcp@v7.30.2...v7.31.0

### [`v7.30.2`](https://togithub.com/pulumi/pulumi-gcp/releases/tag/v7.30.2)

[Compare Source](https://togithub.com/pulumi/pulumi-gcp/compare/v7.30.1...v7.30.2)

##### Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

##### What's Changed

-   Update GitHub Actions workflows. by [@&#8203;pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2170](https://togithub.com/pulumi/pulumi-gcp/pull/2170)
-   Update GitHub Actions workflows. by [@&#8203;pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2172](https://togithub.com/pulumi/pulumi-gcp/pull/2172)
-   Fix PAM entitlement permadiff by enabling PRC by [@&#8203;VenelinMartinov](https://togithub.com/VenelinMartinov) in [https://github.com/pulumi/pulumi-gcp/pull/2174](https://togithub.com/pulumi/pulumi-gcp/pull/2174)

**Full Changelog**: pulumi/pulumi-gcp@v7.30.1...v7.30.2

### [`v7.30.1`](https://togithub.com/pulumi/pulumi-gcp/releases/tag/v7.30.1)

[Compare Source](https://togithub.com/pulumi/pulumi-gcp/compare/v7.30.0...v7.30.1)

##### Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

#### What's Changed

-   Fix cloudrun service auto name by [@&#8203;VenelinMartinov](https://togithub.com/VenelinMartinov) in [https://github.com/pulumi/pulumi-gcp/pull/2163](https://togithub.com/pulumi/pulumi-gcp/pull/2163)
-   Fix cloudrun panic by enabling PRC by [@&#8203;VenelinMartinov](https://togithub.com/VenelinMartinov) in [https://github.com/pulumi/pulumi-gcp/pull/2165](https://togithub.com/pulumi/pulumi-gcp/pull/2165)

**Full Changelog**: pulumi/pulumi-gcp@v7.30.0...v7.30.1

### [`v7.30.0`](https://togithub.com/pulumi/pulumi-gcp/releases/tag/v7.30.0)

[Compare Source](https://togithub.com/pulumi/pulumi-gcp/compare/v7.29.0...v7.30.0)

##### Does the PR have any schema changes?

Found 4 breaking changes:

##### Types

-   "gcp:cloudfunctionsv2/getFunctionBuildConfig:getFunctionBuildConfig": required:
    -   `🟢` "automaticUpdatePolicies" property has changed to Required
    -   `🟢` "onDeployUpdatePolicies" property has changed to Required
-   "gcp:datafusion/InstanceNetworkConfig:InstanceNetworkConfig": required:
    -   `🟢` "ipAllocation" property is no longer Required
    -   `🟢` "network" property is no longer Required

##### New resources:

-   `storage/managedFolder.ManagedFolder`
-   `storage/managedFolderIamBinding.ManagedFolderIamBinding`
-   `storage/managedFolderIamMember.ManagedFolderIamMember`
-   `storage/managedFolderIamPolicy.ManagedFolderIamPolicy`

##### New functions:

-   `storage/getManagedFolderIamPolicy.getManagedFolderIamPolicy`

#### What's Changed

-   Update GitHub Actions workflows. by [@&#8203;pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2120](https://togithub.com/pulumi/pulumi-gcp/pull/2120)
-   Enable TypedDict input types for the Python SDK by [@&#8203;julienp](https://togithub.com/julienp) in [https://github.com/pulumi/pulumi-gcp/pull/2116](https://togithub.com/pulumi/pulumi-gcp/pull/2116)
-   Update GitHub Actions workflows. by [@&#8203;pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2122](https://togithub.com/pulumi/pulumi-gcp/pull/2122)
-   Update GitHub Actions workflows. by [@&#8203;pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2126](https://togithub.com/pulumi/pulumi-gcp/pull/2126)
-   Update GitHub Actions workflows. by [@&#8203;pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2138](https://togithub.com/pulumi/pulumi-gcp/pull/2138)
-   Upgrade pulumi-terraform-bridge to v3.86.0 by [@&#8203;pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2140](https://togithub.com/pulumi/pulumi-gcp/pull/2140)
-   Automatically detect iam resources on tfgen by [@&#8203;guineveresaenger](https://togithub.com/guineveresaenger) in [https://github.com/pulumi/pulumi-gcp/pull/2154](https://togithub.com/pulumi/pulumi-gcp/pull/2154)
-   Update GitHub Actions workflows. by [@&#8203;pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2156](https://togithub.com/pulumi/pulumi-gcp/pull/2156)
-   Upgrade terraform-provider-google-beta to v5.36.0 by [@&#8203;guineveresaenger](https://togithub.com/guineveresaenger) in [https://github.com/pulumi/pulumi-gcp/pull/2153](https://togithub.com/pulumi/pulumi-gcp/pull/2153)

#### New Contributors

-   [@&#8203;julienp](https://togithub.com/julienp) made their first contribution in [https://github.com/pulumi/pulumi-gcp/pull/2116](https://togithub.com/pulumi/pulumi-gcp/pull/2116)

**Full Changelog**: pulumi/pulumi-gcp@v7.29.0...v7.30.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ride-app/platform).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
@mjeffryes mjeffryes added this to the 0.107 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-release/patch When a PR with this label merges, it initiates a release of vX.Y.Z+1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty indexConfig in gcp.firestore.Field shows changes on every update
4 participants