-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix firestore field permadiff by enabling PRC #2182
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
added
the
needs-release/patch
When a PR with this label merges, it initiates a release of vX.Y.Z+1
label
Jul 11, 2024
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
flostadler
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has been shipped in release v7.31.0. |
trunk-io bot
referenced
this pull request
in ride-app/platform
Jul 16, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@pulumi/gcp](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-gcp)) | [`7.29.0` -> `7.31.0`](https://renovatebot.com/diffs/npm/@pulumi%2fgcp/7.29.0/7.31.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@pulumi%2fgcp/7.31.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@pulumi%2fgcp/7.31.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@pulumi%2fgcp/7.29.0/7.31.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@pulumi%2fgcp/7.29.0/7.31.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pulumi/pulumi-gcp (@​pulumi/gcp)</summary> ### [`v7.31.0`](https://togithub.com/pulumi/pulumi-gcp/releases/tag/v7.31.0) [Compare Source](https://togithub.com/pulumi/pulumi-gcp/compare/v7.30.2...v7.31.0) ##### Does the PR have any schema changes? Looking good! No breaking changes found. ##### New resources: - `securesourcemanager/repository.Repository` - `securesourcemanager/repositoryIamBinding.RepositoryIamBinding` - `securesourcemanager/repositoryIamMember.RepositoryIamMember` - `securesourcemanager/repositoryIamPolicy.RepositoryIamPolicy` - `securitycenter/v2OrganizationNotificationConfig.V2OrganizationNotificationConfig` ##### New functions: - `kms/getCryptoKeys.getCryptoKeys` - `kms/getKeyRings.getKeyRings` - `securesourcemanager/getRepositoryIamPolicy.getRepositoryIamPolicy` ##### What's Changed - Fix firestore field permadiff by enabling PRC by [@​VenelinMartinov](https://togithub.com/VenelinMartinov) in [https://github.com/pulumi/pulumi-gcp/pull/2182](https://togithub.com/pulumi/pulumi-gcp/pull/2182) - Fix firestore database resource leak by [@​VenelinMartinov](https://togithub.com/VenelinMartinov) in [https://github.com/pulumi/pulumi-gcp/pull/2187](https://togithub.com/pulumi/pulumi-gcp/pull/2187) - Fix test flake by [@​VenelinMartinov](https://togithub.com/VenelinMartinov) in [https://github.com/pulumi/pulumi-gcp/pull/2188](https://togithub.com/pulumi/pulumi-gcp/pull/2188) - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2192](https://togithub.com/pulumi/pulumi-gcp/pull/2192) - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2194](https://togithub.com/pulumi/pulumi-gcp/pull/2194) - Upgrade terraform-provider-google-beta to v5.37.0 by [@​VenelinMartinov](https://togithub.com/VenelinMartinov) in [https://github.com/pulumi/pulumi-gcp/pull/2193](https://togithub.com/pulumi/pulumi-gcp/pull/2193) **Full Changelog**: pulumi/pulumi-gcp@v7.30.2...v7.31.0 ### [`v7.30.2`](https://togithub.com/pulumi/pulumi-gcp/releases/tag/v7.30.2) [Compare Source](https://togithub.com/pulumi/pulumi-gcp/compare/v7.30.1...v7.30.2) ##### Does the PR have any schema changes? Looking good! No breaking changes found. No new resources/functions. ##### What's Changed - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2170](https://togithub.com/pulumi/pulumi-gcp/pull/2170) - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2172](https://togithub.com/pulumi/pulumi-gcp/pull/2172) - Fix PAM entitlement permadiff by enabling PRC by [@​VenelinMartinov](https://togithub.com/VenelinMartinov) in [https://github.com/pulumi/pulumi-gcp/pull/2174](https://togithub.com/pulumi/pulumi-gcp/pull/2174) **Full Changelog**: pulumi/pulumi-gcp@v7.30.1...v7.30.2 ### [`v7.30.1`](https://togithub.com/pulumi/pulumi-gcp/releases/tag/v7.30.1) [Compare Source](https://togithub.com/pulumi/pulumi-gcp/compare/v7.30.0...v7.30.1) ##### Does the PR have any schema changes? Looking good! No breaking changes found. No new resources/functions. #### What's Changed - Fix cloudrun service auto name by [@​VenelinMartinov](https://togithub.com/VenelinMartinov) in [https://github.com/pulumi/pulumi-gcp/pull/2163](https://togithub.com/pulumi/pulumi-gcp/pull/2163) - Fix cloudrun panic by enabling PRC by [@​VenelinMartinov](https://togithub.com/VenelinMartinov) in [https://github.com/pulumi/pulumi-gcp/pull/2165](https://togithub.com/pulumi/pulumi-gcp/pull/2165) **Full Changelog**: pulumi/pulumi-gcp@v7.30.0...v7.30.1 ### [`v7.30.0`](https://togithub.com/pulumi/pulumi-gcp/releases/tag/v7.30.0) [Compare Source](https://togithub.com/pulumi/pulumi-gcp/compare/v7.29.0...v7.30.0) ##### Does the PR have any schema changes? Found 4 breaking changes: ##### Types - "gcp:cloudfunctionsv2/getFunctionBuildConfig:getFunctionBuildConfig": required: - `🟢` "automaticUpdatePolicies" property has changed to Required - `🟢` "onDeployUpdatePolicies" property has changed to Required - "gcp:datafusion/InstanceNetworkConfig:InstanceNetworkConfig": required: - `🟢` "ipAllocation" property is no longer Required - `🟢` "network" property is no longer Required ##### New resources: - `storage/managedFolder.ManagedFolder` - `storage/managedFolderIamBinding.ManagedFolderIamBinding` - `storage/managedFolderIamMember.ManagedFolderIamMember` - `storage/managedFolderIamPolicy.ManagedFolderIamPolicy` ##### New functions: - `storage/getManagedFolderIamPolicy.getManagedFolderIamPolicy` #### What's Changed - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2120](https://togithub.com/pulumi/pulumi-gcp/pull/2120) - Enable TypedDict input types for the Python SDK by [@​julienp](https://togithub.com/julienp) in [https://github.com/pulumi/pulumi-gcp/pull/2116](https://togithub.com/pulumi/pulumi-gcp/pull/2116) - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2122](https://togithub.com/pulumi/pulumi-gcp/pull/2122) - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2126](https://togithub.com/pulumi/pulumi-gcp/pull/2126) - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2138](https://togithub.com/pulumi/pulumi-gcp/pull/2138) - Upgrade pulumi-terraform-bridge to v3.86.0 by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2140](https://togithub.com/pulumi/pulumi-gcp/pull/2140) - Automatically detect iam resources on tfgen by [@​guineveresaenger](https://togithub.com/guineveresaenger) in [https://github.com/pulumi/pulumi-gcp/pull/2154](https://togithub.com/pulumi/pulumi-gcp/pull/2154) - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2156](https://togithub.com/pulumi/pulumi-gcp/pull/2156) - Upgrade terraform-provider-google-beta to v5.36.0 by [@​guineveresaenger](https://togithub.com/guineveresaenger) in [https://github.com/pulumi/pulumi-gcp/pull/2153](https://togithub.com/pulumi/pulumi-gcp/pull/2153) #### New Contributors - [@​julienp](https://togithub.com/julienp) made their first contribution in [https://github.com/pulumi/pulumi-gcp/pull/2116](https://togithub.com/pulumi/pulumi-gcp/pull/2116) **Full Changelog**: pulumi/pulumi-gcp@v7.29.0...v7.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ride-app/platform). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2166
Enabled PRC for firestore field which prevents a permadiff in the
indexConfig
parameter.