Enable PRC by default in GCP #2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
added
the
needs-release/minor
VenelinMartinov
requested review from
t0yv0,
guineveresaenger,
iwahbe and
corymhall
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
6 tasks
|
Looks like there are some test failures here that may be meaningful. |
|
Yup, will investigate. |
3 tasks
|
This should be good to go after #2305 and the the next bridge release which pulls in pulumi/pulumi-terraform-bridge#2286 |
VenelinMartinov
force-pushed
the
vvm/enable_prc_by_default
branch
from
94773a4
to
24773aa
Compare
The labels tests were asserting on behaviour different to what TF does. The previous assumption was that "" in labels means keep old value but that turns out is not quite correct. Generally, "" is treated as "keep the previous value". However, if the value has always been "", then it is treated as "no value". This trumps any default labels. This PR reworks the labels tests check to assert on the correct behaviour, matching TF. Stacked on #2277 Part of #2280
github-actions
bot
removed
the
needs-release/minor
trunk-io bot
referenced
this pull request
in ride-app/platform
Aug 14, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@pulumi/gcp](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-gcp)) | [`7.35.0` -> `7.36.0`](https://renovatebot.com/diffs/npm/@pulumi%2fgcp/7.35.0/7.36.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pulumi/pulumi-gcp (@​pulumi/gcp)</summary> ### [`v7.36.0`](https://togithub.com/pulumi/pulumi-gcp/releases/tag/v7.36.0) [Compare Source](https://togithub.com/pulumi/pulumi-gcp/compare/v7.35.0...v7.36.0) ##### Does the PR have any schema changes? Looking good! No breaking changes found. No new resources/functions. #### What's Changed - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2302](https://togithub.com/pulumi/pulumi-gcp/pull/2302) - Trim frontmatter from IAM copy by [@​iwahbe](https://togithub.com/iwahbe) in [https://github.com/pulumi/pulumi-gcp/pull/2303](https://togithub.com/pulumi/pulumi-gcp/pull/2303) - Upgrade pulumi-terraform-bridge to v3.89.0 by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2309](https://togithub.com/pulumi/pulumi-gcp/pull/2309) - Enable PRC by default in GCP by [@​VenelinMartinov](https://togithub.com/VenelinMartinov) in [https://github.com/pulumi/pulumi-gcp/pull/2277](https://togithub.com/pulumi/pulumi-gcp/pull/2277) **Full Changelog**: pulumi/pulumi-gcp@v7.35.0...v7.36.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/ride-app/platform). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
](https://renovatebot.com){kind=link}
trunk-io bot
referenced
this pull request
in ride-app/user-service
Aug 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@pulumi/gcp](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-gcp)) | [`7.34.0` -> `7.37.0`](https://renovatebot.com/diffs/npm/@pulumi%2fgcp/7.34.0/7.37.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pulumi/pulumi-gcp (@​pulumi/gcp)</summary> ### [`v7.37.0`](https://togithub.com/pulumi/pulumi-gcp/releases/tag/v7.37.0) [Compare Source](https://togithub.com/pulumi/pulumi-gcp/compare/v7.36.0...v7.37.0) ##### Does the PR have any schema changes? Found 3 breaking changes: ##### Types - `🟢` "gcp:cloudrunv2/getJobBinaryAuthorization:getJobBinaryAuthorization": required: "policy" property has changed to Required - `🟢` "gcp:cloudrunv2/getServiceBinaryAuthorization:getServiceBinaryAuthorization": required: "policy" property has changed to Required - `🟢` "gcp:container/getClusterClusterAutoscaling:getClusterClusterAutoscaling": required: "autoProvisioningLocations" property has changed to Required ##### New resources: - `accesscontextmanager/servicePerimeterDryRunEgressPolicy.ServicePerimeterDryRunEgressPolicy` - `accesscontextmanager/servicePerimeterDryRunIngressPolicy.ServicePerimeterDryRunIngressPolicy` - `securitycenter/v2FolderMuteConfig.V2FolderMuteConfig` - `securitycenter/v2OrganizationSource.V2OrganizationSource` - `securitycenter/v2OrganizationSourceIamBinding.V2OrganizationSourceIamBinding` - `securitycenter/v2OrganizationSourceIamMember.V2OrganizationSourceIamMember` - `securitycenter/v2OrganizationSourceIamPolicy.V2OrganizationSourceIamPolicy` - `securitycenter/v2ProjectMuteConfig.V2ProjectMuteConfig` - `securitycenter/v2ProjectNotificationConfig.V2ProjectNotificationConfig` ##### New functions: - `securitycenter/getV2OrganizationSourceIamPolicy.getV2OrganizationSourceIamPolicy` #### What's Changed - Upgrade terraform-provider-google-beta to v5.41.0 by [@​guineveresaenger](https://togithub.com/guineveresaenger) in [https://github.com/pulumi/pulumi-gcp/pull/2311](https://togithub.com/pulumi/pulumi-gcp/pull/2311) **Full Changelog**: pulumi/pulumi-gcp@v7.36.0...v7.37.0 ### [`v7.36.0`](https://togithub.com/pulumi/pulumi-gcp/releases/tag/v7.36.0) [Compare Source](https://togithub.com/pulumi/pulumi-gcp/compare/v7.35.0...v7.36.0) ##### Does the PR have any schema changes? Looking good! No breaking changes found. No new resources/functions. #### What's Changed - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2302](https://togithub.com/pulumi/pulumi-gcp/pull/2302) - Trim frontmatter from IAM copy by [@​iwahbe](https://togithub.com/iwahbe) in [https://github.com/pulumi/pulumi-gcp/pull/2303](https://togithub.com/pulumi/pulumi-gcp/pull/2303) - Upgrade pulumi-terraform-bridge to v3.89.0 by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2309](https://togithub.com/pulumi/pulumi-gcp/pull/2309) - Enable PRC by default in GCP by [@​VenelinMartinov](https://togithub.com/VenelinMartinov) in [https://github.com/pulumi/pulumi-gcp/pull/2277](https://togithub.com/pulumi/pulumi-gcp/pull/2277) **Full Changelog**: pulumi/pulumi-gcp@v7.35.0...v7.36.0 ### [`v7.35.0`](https://togithub.com/pulumi/pulumi-gcp/releases/tag/v7.35.0) [Compare Source](https://togithub.com/pulumi/pulumi-gcp/compare/v7.34.0...v7.35.0) ##### Does the PR have any schema changes? Found 2 breaking changes: ##### Types - `🟢` "gcp:sql/getDatabaseInstanceSetting:getDatabaseInstanceSetting": required: "enableDataplexIntegration" property has changed to Required - `🟢` "gcp:sql/getDatabaseInstancesInstanceSetting:getDatabaseInstancesInstanceSetting": required: "enableDataplexIntegration" property has changed to Required No new resources/functions. #### What's Changed - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-gcp/pull/2283](https://togithub.com/pulumi/pulumi-gcp/pull/2283) - Upgrade terraform-provider-google-beta to v5.40.0 by [@​iwahbe](https://togithub.com/iwahbe) in [https://github.com/pulumi/pulumi-gcp/pull/2284](https://togithub.com/pulumi/pulumi-gcp/pull/2284) **Full Changelog**: pulumi/pulumi-gcp@v7.34.0...v7.35.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone Asia/Kolkata, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/ride-app/user-service). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rolls out PlanResourceChange to GCP.
Part of pulumi/pulumi-terraform-bridge#1785