Update Go Helm v3 to use native client #1296
Conversation
|
Note: I changed the tests to test both v2 and v3 and expect no changes between them. I also updated the Chart that is deployed because the previous one is deprecated and will stop working at some point when the k8s cluster version gets bumped. |
| @@ -0,0 +1,312 @@ | |||
| // Copyright 2016-2020, Pulumi Corporation. | |||
There was a problem hiding this comment.
Any particular reason why this file is templated? It doesn't seem to have any substitutions as far as I can tell. Just makes it a little more cumbersome to review. Same goes for the types defined below.
There was a problem hiding this comment.
IIRC, I did that to keep the Go linter from complaining. I think it was trying to analyze the templates in place and was failing since the paths are wrong unless the files are in the SDK folder. It's not necessary otherwise.
| Untar *bool `pulumi:"untar"` | ||
| Verify *bool `pulumi:"verify"` | ||
| Version string `json:"version,omitempty" pulumi:"version"` | ||
| CAFile string `json:"ca_file,omitempty" pulumi:"caFile"` |
There was a problem hiding this comment.
Curious on the json tags: does snake casing here match with what is expected in helm? (as opposed to camelCase or others)
There was a problem hiding this comment.
This matches the JSON structure expected by the invoked function. It's not used by Helm directly; it's just the way I defined the interface rather than passing a huge bag of args.
Proposed changes
Related issues (optional)
Part of #920