Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly compute plugin version for PEP440 style prereleases #733

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

ellismg
Copy link
Contributor

@ellismg ellismg commented Aug 22, 2019

Fixes #732

Copy link
Member

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and manually verified this fixes things for me.

@ellismg ellismg merged commit 8127e8c into master Aug 22, 2019
@pulumi-bot pulumi-bot deleted the ellismg/fix-732 branch August 22, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_version() does not handle PEP440 style pre-releases
2 participants