Fix array output property typing for .NET #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were typing these as `Output<T[]>`, but the .NET deserialization only supports `Output<ImmutableArray<T>>`.
Create a `RoleBinding` which has a `Subjects` output of type `Output<ImmutableArray<>>`.
lblackstone
approved these changes
Dec 19, 2019
lblackstone
reviewed
Dec 19, 2019
lblackstone
reviewed
Dec 19, 2019
|
Still can't figure out the CI test user credentials in GKE - so have disabled this new test coverage for now. Would love to re-enable if we can fix up the CI user permissions (or the RoleBinding specification). |
CyrusNajmabadi
approved these changes
Dec 20, 2019
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were typing these as
Output<T[]>, but the .NET deserialization only supportsOutput<ImmutableArray<T>>.Fixes #926.