Add support for cloning private repos as part of automation API #5333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBoyle
reviewed
Sep 11, 2020
metral
suggested changes
Sep 11, 2020
stack72
force-pushed
the
stack72/gh-5319
branch
from
8232bf5
to
5e35fa5
Compare
stack72
force-pushed
the
stack72/gh-5319
branch
from
5e35fa5
to
a194663
Compare
metral
suggested changes
Sep 14, 2020
stack72
force-pushed
the
stack72/gh-5319
branch
from
a194663
to
72d4ada
Compare
🎉
stack72
force-pushed
the
stack72/gh-5319
branch
from
72d4ada
to
e335103
Compare
justinvp
reviewed
Sep 14, 2020
| fqsn := FullyQualifiedStackName("myOrg", pName, "myStack") | ||
|
|
||
| repo := GitRepo{ | ||
| URL: "https://github.com/pulumi/test-repo.git", |
There was a problem hiding this comment.
Interesting, I thought you'd have to specify the URL like git@github.com:pulumi/test-repo.git when using SSH for auth, but it works when doing HTTPS?. Do the git@... style URLs work as well?
There was a problem hiding this comment.
@stack72 Just ran into this for the operator, and the URL does in fact need to be git@github.com... as Justin points out.
Using the HTTPS url results in unable to clone repo: invalid auth method
This was referenced Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5319