Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go Modules #226

Merged
merged 5 commits into from
Feb 10, 2020
Merged

Go Modules #226

merged 5 commits into from
Feb 10, 2020

Conversation

pda
Copy link
Contributor

@pda pda commented Feb 7, 2020

Use Go Modules to manage dependencies, instead of committing them all in vendor/ and tracking them with vendor.json.

This was basically done by:

go mod init github.com/puma/puma-dev
go mod download
go build ./cmd/puma-dev
go test ./...

The tests pass with the resulting go.mod on my Linux environment when combined with the Linux fix in #225

@pda
Copy link
Contributor Author

pda commented Feb 10, 2020

I've rebased this onto the now-merged #227 so that modules work in CI, which should give some confidence that this change is 👌

image

@nateberkopec nateberkopec merged commit ddadeac into puma:master Feb 10, 2020
@pda pda deleted the go-modules branch March 19, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants