ActivityStreams 2.0 #1483

strugee · 2017-10-26T01:26:25Z

Resolves #851

coveralls · 2017-11-05T23:59:31Z

Coverage decreased (-3.7%) to 70.08% when pulling a6bfb17 on as2 into 5bf9335 on master.

ghost · 2017-11-06T00:02:23Z

routes/api.js

@@ -303,7 +311,7 @@ var getObject = function(req, res, next) {
                next(err);
            } else {
                obj.sanitize();
-                res.json(obj);
+                res.json(wantAS2(req) ? as2(obj) : obj);


I thinks this could be put in a function like "handleAS2" for prevent repeating code (line 547 is the same code)

Nice catch, thanks 👍

Fixed this locally, will push soon

coveralls · 2017-11-06T02:03:33Z

Coverage decreased (-3.7%) to 70.088% when pulling 58af0b5 on as2 into 5bf9335 on master.

coveralls · 2017-11-06T02:03:33Z

Coverage decreased (-3.7%) to 70.088% when pulling 58af0b5 on as2 into 5bf9335 on master.

coveralls · 2017-11-06T02:03:33Z

Coverage decreased (-3.7%) to 70.088% when pulling 58af0b5 on as2 into 5bf9335 on master.

coveralls · 2017-11-06T04:54:25Z

Coverage decreased (-3.7%) to 70.082% when pulling 7f934e4 on as2 into 5bf9335 on master.

strugee · 2017-11-06T04:55:56Z

The tentative plan is to capitalize all verbs that have been straight up dropped and rename verbs when they have been fully renamed or subsumed by another Activity type. We'll do the same for object types, but we'll use Tombstones specially.

Here's the complete list of differences between AS1 and AS2 verb vocabularies:

Dropped: access
Renamed: share -> Announce
Not dropped and I think it doesn't have different semantics: add
Dropped: agree
Dropped: append
Dropped: approve
Dropped: archive
Dropped: assign
Dropped: at
Subsumed: attach by Add
Dropped: attend
Dropped: author verb (note: more specific form of AS1 create)
Dropped: authorize
Dropped: borrow
Dropped: build
Dropped: cancel
Dropped: close
Dropped: complete
Dropped: confirm
Dropped: consume (maybe subsumed by others?)
Dropped: checkin
Dropped: deliver
Dropped: deny
Dropped: disagree
Dropped: experience
Subsumed: favorite by like
Dropped: find
Renamed: flag-as-inappropriate to Flag
Dropped: give
Dropped: host
Dropped: insert
Dropped: install
Dropped: interact
Dropped: lose
Dropped: make-friend
Dropped: open
Subsumed: play by View
Dropped: present
Dropped: purchase
Dropped: qualify
Dropped: receive
Dropped: remove-friend
Dropped: replace
Dropped: request
Dropped: request-friend
Dropped: resolve
Dropped: return
Dropped: retract
Subsumed: rsvp-maybe by TentativeAccept
Subsumed: rsvp-no by Reject
Subsumed: rsvp-yes by Accept
Dropped: satisfy
Dropped: save
Dropped: schedule
Dropped: search
Dropped: sell
Dropped: send
Renamed: share to Announce
Dropped: sponsor
Dropped: start
Subsumed: stop-following by Undo
Subsumed: submit with a target by Add (maybe?)
Subsumed: submit without a target by Create
Dropped: tag
Dropped: terminate
Dropped: tie
Subsumed: unfavorite by Undo
Subsumed: unlike by Undo
Subsumed: unsatisfy by Undo
Subsumed: unsave by Undo
Subsumed: unshare by Undo
Dropped: use
Subsumed: watch by View
Dropped: win
Added: Arrive
Added: Block
Added: Move
Added: Offer
Added: TentativeReject
Added: TentativeAccept
Added: Travel

And here's the list of object type vocabulary differences:

Dropped: alert
Dropped: badge
Dropped: binary
Dropped: bookmark
Dropped: comment (subsumed by Note...???)
Dropped: device
Dropped: file
Dropped: game
Dropped: group
Dropped: issue
Dropped: job
Dropped: offer
Dropped: permission
Dropped: process
Dropped: product
Dropped: question
Dropped: review
Dropped: role (subsumed by Relationship, maybe?)
Dropped: task
Dropped: team
Added: Document
Added: Profile
Added: Relationship
Added: Tombstone
Added: Mention

coveralls · 2017-11-06T06:26:03Z

Coverage decreased (-0.01%) to 73.79% when pulling d6ad7d1 on as2 into 5bf9335 on master.

detrout · 2017-11-07T04:50:30Z

Thats a lot of changes... is there a way to tell a client that terms are deprecated and give them a chance to adapt? Did the endpoint change or is there a version number so a client can tell that it wont work now?

Just thoughts... Not sure whats truly necessary for activity streams migration

ghost · 2017-11-07T05:05:16Z

lib/as2.js

+    as2["@id"] = as2.id;
+    delete as2.id;
+
+    if (as2.verb === "post") {


If you change the verb, need to change this #L145 or change the name of Activity.prototype.apply[Method]

Don't need to change anything outside of this file since this runs so late in the request-response cycle. Basically everywhere else doesn't have to care.

You only change the output/response?

What will happened with the petitions?, if comes the request with AS2, it transform to AS1 before process/save?

@vxcamiloxv we don't support AS2 submissions yet but when we do that'll be how it works. At least for the time being.

Eventually we'll want to move to AS2 storage but. Not yet. We want the API to stabilize, etc.

I think will be strange (and confusing), if the input is AS1 and the output AS2, for the external apps could be more work (migrate the output and later the input) and probability cause more side effects and more errors.

I think is better one big change a not change by parts, is better one migration than 2 big migrations in a short period of time, mostly when is related with the input/output of a API

@vxcamiloxv I would agree with you except that AS2 output is opt-in. So if clients don't want to deal with the hassle of consuming two different formats in input and output (I certainly wouldn't), they don't have to. They can just wait for AS2 input to ship too.

Ha ok, yes, probably they will wait for full implementation

strugee · 2017-11-07T05:44:25Z

@detrout endpoints do HTTP content negotiation. Clients only get this representation if they specifically ask for AS2 in the Accept header.

strugee · 2017-11-07T05:45:14Z

So to be clear, this is fully backwards-compatible and will ship as semver-minor.

strugee · 2017-11-09T16:11:48Z

Since writing this vocab plan I've found https://github.com/snarfed/granary (/cc @snarfed); we should try to align with that processing model. Otherwise I think this is ready to implement.

puckipedia · 2017-11-17T20:30:20Z

So quick note: It seems there's no @context in the AS2 representation. Together with this, the AS2 context defines type to be an alias of @type and idto alias @id, so those should be used instead as well :)

for the rest, I'm more than willing to test stuff against Kroeg for interop testing :P

coveralls · 2017-11-22T23:31:27Z

Coverage increased (+0.1%) to 73.908% when pulling 9828f3c on as2 into f0d30e2 on master.

coveralls · 2017-12-04T02:53:37Z

Coverage decreased (-3.7%) to 70.087% when pulling 3df16ad on as2 into a5b7b9b on master.

coveralls · 2017-12-04T04:29:19Z

Coverage increased (+0.2%) to 74.224% when pulling e596168 on as2 into 3637b31 on master.

strugee · 2018-02-07T18:47:14Z

Here's the current list of TODOs:

Normalize well-known Public collection ids
Write a compatibility @context for dropped vocabulary terms
Properly output Undo activitites

If people complain, we can readd these. But better to start with them gone and add them later, rather than have to go through a full semver-major cycle in order to remove them later. Also, these were dropped for a reason. There was no actual evidence of `upstreamDuplicates` and `downstreamDuplicates` being used, and `title` was deprecated for similar reasons. So it just doesn't seem worth supporting them.

Test using OAuth 2.0 with the actor route. This required the following changes: - Bearer tokens in the configuration file format - Loosen anyReadAuth() to allow OAuth 2.0 - Change the profile route to do content negotiation - Change Actor test to provide a bearer token

strugee · 2018-04-09T23:16:33Z

@evanp to answer your question on IRC - I'm down to merge this whenever provided that a) tests are passing and b) nothing is half-implemented or whatever. I'll try to do a code review tonight 👍

avoid problems

strugee force-pushed the as2 branch from 6c40eab to a7601a8 Compare November 5, 2017 22:28

ghost reviewed Nov 6, 2017

View reviewed changes

strugee force-pushed the as2 branch from 7f934e4 to d6ad7d1 Compare November 6, 2017 05:42

ghost reviewed Nov 7, 2017

View reviewed changes

strugee force-pushed the as2 branch from d6ad7d1 to 9828f3c Compare November 22, 2017 22:47

strugee mentioned this pull request Nov 22, 2017

AS2 vocab translation coordination/funkiness snarfed/granary#116

Open

4 tasks

strugee mentioned this pull request Nov 22, 2017

Extract AS2 conversion routines into a module #1499

Open

strugee force-pushed the as2 branch 2 times, most recently from b58ff4e to 3df16ad Compare December 4, 2017 01:29

strugee force-pushed the as2 branch 2 times, most recently from 4c83afc to 93b2c92 Compare January 26, 2018 00:55

strugee assigned evanp Feb 16, 2018

strugee added 2 commits March 24, 2018 12:10

Start implementing AS1 to AS2 conversion

3e0f76d

evanp added 24 commits April 7, 2018 19:59

Merge branch 'master' into as2

b2b4555

Merge branch 'master' into as2

d2f4c0b

Allow passing a pre-defined token to BearerToken

ed2e85d

Test utility to do a simple get

85f802a

Content negotiation to choose a middleware stack

f00cc14

Update package-lock.json

4a3d191

Remove cred from topic

bcc03eb

Use OAuth 2.0 for ActivityPub followers test

0ed9593

Use OAuth 2.0 for ActivityPub following test

24b7557

Remove unused helper function

5dcf14c

Fake bearer tokens need user nickname

299b403

userReadAuth() includes OAuth 2.0 auth

e38d609

Use OAuth 2.0 for ActivityPub inbox get test

df61616

Use OAuth 2.0 for ActivityPub outbox get test

ce38869

Merge branch 'master' into as2

b75568f

Remove package-lock.json accidentally added

7ab25e0

OAuth 2.0 for ActivityPub likes endpoint

848fc48

Fix quotes and semicolons for lint

9b3dd78

try to convert -> convert

a442df5

Handle the 'undo' verbs in AS2 conversion

3c7436f

likes -> liked

a167b82

Allow passing token and secret to AccessToken constructor

8f4423a

Better differentiation between OAuth 1.0 and 2.0 tokens

0a4c0f9

Try running test:install as regular travis user

e596168

Fix typo

0e18d5b

evanp merged commit 0e18d5b into master Apr 27, 2018

strugee deleted the as2 branch July 13, 2018 00:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ActivityStreams 2.0 #1483

ActivityStreams 2.0 #1483

strugee commented Oct 26, 2017

coveralls commented Nov 5, 2017 •

edited

Loading

ghost Nov 6, 2017

strugee Nov 6, 2017

coveralls commented Nov 6, 2017 •

edited

Loading

coveralls commented Nov 6, 2017

coveralls commented Nov 6, 2017 •

edited

Loading

coveralls commented Nov 6, 2017 •

edited

Loading

strugee commented Nov 6, 2017 •

edited

Loading

coveralls commented Nov 6, 2017 •

edited

Loading

detrout commented Nov 7, 2017

ghost Nov 7, 2017

strugee Nov 7, 2017

ghost Nov 7, 2017

strugee Nov 7, 2017

ghost Nov 7, 2017

strugee Nov 8, 2017

ghost Nov 8, 2017

strugee commented Nov 7, 2017

strugee commented Nov 7, 2017

strugee commented Nov 9, 2017

puckipedia commented Nov 17, 2017 •

edited

Loading

coveralls commented Nov 22, 2017 •

edited

Loading

coveralls commented Dec 4, 2017 •

edited

Loading

coveralls commented Dec 4, 2017 •

edited

Loading

strugee commented Feb 7, 2018

strugee commented Apr 9, 2018

ActivityStreams 2.0 #1483

ActivityStreams 2.0 #1483

Conversation

strugee commented Oct 26, 2017

coveralls commented Nov 5, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Nov 6, 2017 • edited Loading

coveralls commented Nov 6, 2017

coveralls commented Nov 6, 2017 • edited Loading

coveralls commented Nov 6, 2017 • edited Loading

strugee commented Nov 6, 2017 • edited Loading

coveralls commented Nov 6, 2017 • edited Loading

detrout commented Nov 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

strugee commented Nov 7, 2017

strugee commented Nov 7, 2017

strugee commented Nov 9, 2017

puckipedia commented Nov 17, 2017 • edited Loading

coveralls commented Nov 22, 2017 • edited Loading

coveralls commented Dec 4, 2017 • edited Loading

coveralls commented Dec 4, 2017 • edited Loading

strugee commented Feb 7, 2018

strugee commented Apr 9, 2018

coveralls commented Nov 5, 2017 •

edited

Loading

coveralls commented Nov 6, 2017 •

edited

Loading

coveralls commented Nov 6, 2017 •

edited

Loading

coveralls commented Nov 6, 2017 •

edited

Loading

strugee commented Nov 6, 2017 •

edited

Loading

coveralls commented Nov 6, 2017 •

edited

Loading

puckipedia commented Nov 17, 2017 •

edited

Loading

coveralls commented Nov 22, 2017 •

edited

Loading

coveralls commented Dec 4, 2017 •

edited

Loading

coveralls commented Dec 4, 2017 •

edited

Loading