(maint) Fix linking errors on AIX, Solaris, Cisco, and Windows #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA signed by all contributors. |
This was referenced Sep 23, 2016
MikaelSmith
suggested changes
Sep 23, 2016
| SET(BOOST_COMPONENTS thread date_time chrono system program_options) | ||
|
|
||
| if(LEATHERMAN_USE_LOCALES) | ||
| list(APPEND BOOST_COMPONENTS locale) |
There was a problem hiding this comment.
locale depends on system, I'd suggest prepending this.
| @@ -80,7 +80,6 @@ add_library(lib${PROJECT_NAME} $<TARGET_OBJECTS:libprojectsrc>) | |||
| set_target_properties(lib${PROJECT_NAME} PROPERTIES VERSION "${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}") | |||
| target_link_libraries(lib${PROJECT_NAME} | |||
| ${LEATHERMAN_LIBRARIES} | |||
| ${Boost_LIBRARIES} | |||
There was a problem hiding this comment.
This surprises me. I suppose we might only be using things that are header-only (or get everything we need from Leatherman).
There was a problem hiding this comment.
It surprised me too. This one fixed one of the multiple definitions errors on Windows when linking Facter against cpp-hocon...
Magisus
force-pushed
the
more-boost
branch
2 times, most recently
from
8ab2b95 to
6d0affb
Compare
MikaelSmith
approved these changes
Sep 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been run against a full platform set, with successful builds on all of them. Before this can be included in puppet-agent, Facter will need to be updated with similar conditionals around boost::locale.