Feature/facter 2/fact 185 structured ec2 metadata #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When testing a resolution, the confines may be tested to confirm suitability on a given platform and so may be changed without destroying and recreating the resolution. Because of this we need to recalculate suitability every time #suitable? method is invoked. In normal operation fact suitability is only determined once so this should have no performance impact.
The existing EC2 API implemented all methods on a module object, which made for a rather clumsy API that required intrusive stubbing to test. This commit implements a new object based API that should be cleaner to use.
With commit 5ca456f we have a new method of querying the EC2 API; the old methods can be deprecated.
|
CLA signed by all contributors. |
kylog
pushed a commit
that referenced
this pull request
Apr 16, 2014
…ructured-ec2-metadata Feature/facter 2/fact 185 structured ec2 metadata
adrienthebo
deleted the
feature/facter-2/fact-185-structured-ec2-metadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #657