Skip to content

(NETDEV-44) Add logfile and buffered fields to syslog_settings #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2018
Merged

(NETDEV-44) Add logfile and buffered fields to syslog_settings #47

merged 1 commit into from
Sep 12, 2018

Conversation

willmeek
Copy link
Contributor

No description provided.

shermdog
shermdog reviewed Aug 30, 2018
View reviewed changes
lib/puppet/type/syslog_settings.rb Outdated
desc: "Logfile file name to use or 'unset'"
},
logfile_size: {
type: 'Optional[Integer[4096, 2147483647]]',
Copy link
Contributor

@shermdog shermdog Aug 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willmeek I believe we wanted to drop the range checking here as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shermdog Apologies I had the changes sitting locally and forgot to push them up! Should be there now :)

@willmeek willmeek mentioned this pull request Sep 10, 2018
Merged
@shermdog shermdog merged commit df117c7 into puppetlabs:master Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@shermdog shermdog shermdog left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willmeek @shermdog