Skip to content

(MAINT) Fix test Puppet versions #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2023
Merged

(MAINT) Fix test Puppet versions #1201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions spec/acceptance/version_changer_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
end
end

%w[7.3.0 6.19.1].each do |puppet_version|
%w[7.22.0 6.29.0].each do |puppet_version|
context "when requesting --puppet-version #{puppet_version}" do
describe command("pdk validate --puppet-version #{puppet_version}") do
its(:exit_status) { is_expected.to eq(0) }
Expand All @@ -34,13 +34,16 @@
end
end

{ '2019.8.4' => '6.19.1' }.each do |pe_version, puppet_version|
context "when requesting --pe-version #{pe_version}" do
# PE mapping test have been marked as pending due to an issue with concurrent-ruby versions in
# older Puppet gems. This is being tracked and will be resolved in a future version.
{ '2021.7.1' => '7.20.0' }.each do |pe_version, puppet_version|
xcontext "when requesting --pe-version #{pe_version}" do
describe command("pdk validate --pe-version #{pe_version}") do
its(:exit_status) { is_expected.to eq(0) }
end

describe file('Gemfile.lock') do
its(:exit_status) { is_expected.to eq(0) }
it { is_expected.to exist }
its(:content) { is_expected.to match(%r{^\s+puppet \(#{Regexp.escape(puppet_version)}(\)|-)}im) }
end
Expand Down