Fixup acceptance tests for new pdk-templates rubocop config #934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotje
changed the title
scotje
force-pushed
the
fixup_acceptance_rubocop
branch
from
f7f0a29 to
b196ac9
Compare
scotje
force-pushed
the
fixup_acceptance_rubocop
branch
from
e144269 to
e3fa0ea
Compare
scotje
force-pushed
the
fixup_acceptance_rubocop
branch
from
e3fa0ea to
07ca839
Compare
|
I noticed there was an error related to my debugger gem. I recently released 1.0 which required puppet 5.5 because I needed api calls out of it. Because 5.3.2 is being requested the dependency is failing. You have 2 options: Test with ruby 2.4 which pulls down debugger < 1.0.0 or use puppet 5.5. |
|
@scotje is it time to drop puppet 5 altogether? |
|
Closing this and consolidating fixes into #933 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.