Windows updates #60
Merged
Windows updates #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For whatever reason, the anchors associated with puppet configuration properties do not contain underscores, e.g. #caserver, not #ca_server.
By default, puppet manages files in binary mode (so now line-ending translation is performed). The special cases are flat file types, e.g. hosts.
The first component of the id fact is the DOMAIN, which in the case of a local user is the local machine. But in the case of a domain user acount, it would be the AD domain.
The `path` and `default` values for puppet's data directory were inconsistent. The former did not include the `\puppet` directory, whereas the latter did. Also, updated references in the documentation to the data directory, and files relative to it, e.g. `var\log\puppetd.log`.
Fix case of drive letter to be consistently uppercase, and added missing ending parenthesis.
Windows APIs actually support both forward and backslashes, but not all programs, e.g. msiexec, cmd, support forward slashes. So really, people should use forward slashes unless the executable they are trying to run doesn't support it.
I don't think we need to document at this level of detail, especially as the line number won't match as changes are made to this file, and the repo may be renamed shortly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.