Skip to content
This repository was archived by the owner on May 11, 2019. It is now read-only.

Fix #1889 - Align fat arrows #14

Closed
wants to merge 1 commit into from
Closed

Fix #1889 - Align fat arrows #14

wants to merge 1 commit into from

Conversation

dgellow
Copy link

@dgellow dgellow commented Jul 24, 2014

Fix PUP-1889.

Format resource's attributes according to the style guide, section
9.2 "Arrow Alignment"
.

Current behaviour

I have a resource Exec['test']. If I indent the code (with for exemple indent-region), nothing happen.

    exec { 'test':
      subscribe => File['/etc/test'],
      refreshonly => true, | ;; cursor is here
    }

Hit Tab, or select resource and call indent-region.
Nothing change.

New behaviour

Same resource, attributes are formatted with Tab, C-m, C-j,
indent-region, etc.

    exec { 'test':
      subscribe => File['/etc/test'],
      refreshonly => true, | ;; <- cursor is here
    }

Hit Tab. Attributes are formatted.

    exec { 'test':
      subscribe   => File['/etc/test'],
      refreshonly => true, | ;; <- cursor is here
    }

Format resource's attributes according to the style guide, section
9.2 "Arrow Alignment"[1].

Current behaviour:
I have a resource Exec['test']. If I indent the code (with for exemple `indent-region`), nothing happen.

    exec { 'test':
      subscribe => File['/etc/test'],
      refreshonly => true, | ;; cursor is here
    }

    Hit Tab, or select resource and call `indent-region`.

    exec { 'test':
      subscribe => File['/etc/test'],
      refreshonly => true, | ;; cursor is here
    }

New behaviour:
Same resource, attributes are formatted with Tab, C-m, C-j,
`indent-region`, etc.

    exec { 'test':
      subscribe => File['/etc/test'],
      refreshonly => true, | ;; <- cursor is here
    }

    Hit Tab. Attributes are formatted.

    exec { 'test':
      subscribe   => File['/etc/test'],
      refreshonly => true, | ;; <- cursor is here
    }

[1] http://docs.puppetlabs.com/guides/style_guide#arrow-alignment
@puppetcla
Copy link

Waiting for CLA signature by @dgellow

@dgellow - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppetlabs.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppetlabs.com/community/trivial_patch_exemption.html

@dgellow
Copy link
Author

dgellow commented Aug 3, 2014

@puppetcla done

@puppetcla
Copy link

CLA signed by all contributors.

@ahpook
Copy link

ahpook commented May 10, 2019

superseded by voxpupuli/puppet-mode

@ahpook ahpook closed this May 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants