Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-1491) - Fix broken forge urls in Puppetfile #850

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented Oct 11, 2023

Summary

This PR fixes an issue where when hovering over a module in a Puppetfile, the forge url shown would be invalid.

This PR aims to fix this by fixing the url, in the format now used in forge urls.

Additional Context

Before:
image
After:
image

Related Issues (if any)

Fixes #824

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@jordanbreen28 jordanbreen28 requested a review from a team as a code owner October 11, 2023 14:10
@jordanbreen28 jordanbreen28 force-pushed the CAT-1491-fix_broken_module_links branch from 4b0155d to 20e0706 Compare October 11, 2023 14:10
This commit fixes an issue where when hovering over a module in a
Puppetfile, the forge url shown would be invalid.

This commit aims to fix this by fixing the url, in the format now used
in forge urls.
@jordanbreen28 jordanbreen28 force-pushed the CAT-1491-fix_broken_module_links branch from 20e0706 to c6f3bf3 Compare October 11, 2023 15:14
Copy link
Contributor

@GSPatton GSPatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and this fix works

@GSPatton GSPatton merged commit e2b16c1 into main Oct 11, 2023
4 checks passed
@GSPatton GSPatton deleted the CAT-1491-fix_broken_module_links branch October 11, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong URL when showing info about a module in Puppetfile
2 participants