(PUP-5014) Base class for JSON indirection terminus calls #4145
Conversation
|
@tdevelioglu good catch! We did a quick audit and it looks like puppet/lib/puppet/indirector/msgpack.rb Line 26 in fb15a86 Do you mind extending your patch to include a fix for that one too? |
|
Thanks the controbution @tdevelioglu! In addition to Kylo's comment, would you mind fixing up your commit message a little bit? It would be a little clearer if you described what the fix is (passing the exception into log_exception) and why the fix was necessary (this broke formatting further down the line and caused puppet to raise an error) rather than just describing the issue. |
tdevelioglu
force-pushed
the
fix/master/PUP-5014_fix_log_exception_in_json_catalog_terminus
branch
from
03e7a47
to
7b4ad7a
Compare
log_exception() wrong Puppet::Indirector::JSON and Puppet::Indirector::Msgpack call Puppet.log_exception() without a mandatory exception as the first argument value, passing the message string instead. This breaks further along in format_exception() when it attempts to get the exception message attribute but finds a string, resulting in a NoMethodError raised by the puppet agent. This commit fixes the issue by passing the raised exception to log_exception() as required first, and the message second.
tdevelioglu
force-pushed
the
fix/master/PUP-5014_fix_log_exception_in_json_catalog_terminus
branch
from
7b4ad7a
to
9d2e0ed
Compare
|
@HAIL9000 |
…_exception_in_json_catalog_terminus (PUP-5014) Base class for JSON indirection terminus calls
|
Thanks again, @tdevelioglu ! |
|
@HAIL9000 in our triage notes, you were going to grep jira for tickets that might map to this. Did you get a chance to do that? |
|
@kylog Not yet! I'll make some time for that this week |
log_exception() wrong.
In Puppet::Indirector::JSON, Puppet.log_exception() is called without
the required exception as the first argument value, instead the message
is passed.
This breaks further along in format_exception() as it attempts to get
the exception message attribute but finds a string: