(maint) Support dotted env vars in containers #3401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Both docker (per moby/moby#16585) and Kubernetes (per kubernetes/kubernetes#2707) support passing environment variables with dots as config, despite dot not technically being supported in POSIX. This is necessary to be able to specify hocon array values like FOO.0, FOO.1, etc now that the Hocon library is updated to typesafe/config 1.4.1 via puppetlabs/typesafe-config 0.2.0 / clj-parent 4.6.11 /bin/sh will not add such variables to the environment, but /bin/bash will properly expose them, so that they may be consumed by puppetserver and hocon. NOTE: ElasticSearch is notorious for passing such values, and it also uses the tini init system, so it served as a good design to follow: https://github.com/elastic/elasticsearch/tree/master/distribution/docker
nwolfe
approved these changes
Jan 27, 2021
binford2k
referenced
this pull request
in voxpupuli/container-puppetdb
Nov 1, 2022
(maint) Support dotted env vars in containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both docker (per Docker 1.8 - no longer able to pass Spring config settings in env-file moby/moby#16585) and
Kubernetes (per dot character in environment variable name yields "invalid value" kubernetes/kubernetes#2707)
support passing environment variables with dots as config, despite
dot not technically being supported in POSIX.
This is necessary to be able to specify hocon array values like
FOO.0, FOO.1, etc now that the Hocon library is updated to
typesafe/config 1.4.1 via puppetlabs/typesafe-config 0.2.0 /
clj-parent 4.6.11
/bin/sh will not add such variables to the environment, but /bin/bash
will properly expose them, so that they may be consumed by
puppetserver and hocon.
NOTE: ElasticSearch is notorious for passing such values, and it also
uses the tini init system, so it served as a good design to follow:
https://github.com/elastic/elasticsearch/tree/master/distribution/docker