Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#FORGE-288 Apache::vhost module should support raw vhost configuration #1259

Closed
wants to merge 4 commits into from

Conversation

yrobla
Copy link

@yrobla yrobla commented Nov 11, 2015

Add a new raw_vhost parameter to apache::vhost . This parameter will be a string, that will allow to configure a vhost externally, passing a string with the final content.
For certain use cases, it will be simpler and will add also the flexibility needed.

Yolanda Robla added 4 commits November 11, 2015 10:41
It will allow to pass a raw content to define a vhost,
instead of relying on parameters and concat templates.
@igalic
Copy link
Contributor

igalic commented Nov 12, 2015

@yrobla thank you very much for this patch
please note that it's not merging cleanly anymore, and hence needs a rebase. I'd also very much appreciate a squash.

you're also introducing this new feature that changes a lot of existing code, without any tests :|

@pabelanger
Copy link
Contributor

+1

@dteirney
Copy link

Is there something that this approach achieves that the existing $custom_fragment can't address? I've managed to get quite far with the various standard parameters and then putting what else was needed into the custom_fragment.

@yrobla
Copy link
Author

yrobla commented Nov 13, 2015

I will be closing. As discussed on the modules meeting, a new vhost::custom will be created, to allow to pass raw configuration.

@yrobla yrobla closed this Nov 13, 2015
@yrobla yrobla deleted the apache_raw_vhost branch November 13, 2015 07:34
@igalic
Copy link
Contributor

igalic commented Nov 17, 2015

pinging @hunner who wanted to submit this pr :)

@hunner
Copy link
Contributor

hunner commented Nov 19, 2015

@igalic Sorry, I think @pabelanger had volunteered to make apache::vhost::custom that wrapped apache::custom_config

@pabelanger
Copy link
Contributor

Ya, I've started something already. Hope to have something in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants