Skip to content

Replace some occurrences of non-ASCII chars #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2020

Conversation

DLeich
Copy link
Contributor

@DLeich DLeich commented Sep 28, 2020

Several lines in the comments of apache::vhost and apache::mod::jk have non-ascii characters embedded. This can throw off some testing suites, such as Oneceover, which will complain about it. This pull request replaces non-ascii characters with acceptable alternatives.

@DLeich DLeich requested a review from a team as a code owner September 28, 2020 15:04
@puppet-community-rangefinder
Copy link

apache::mod::jk is a class

that may have no external impact to Forge modules.

apache::vhost is a type

Breaking changes to this file WILL impact these 125 modules (exact match):
Breaking changes to this file MAY impact these 32 modules (near match):

This module is declared in 174 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@5323b8d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2070   +/-   ##
=======================================
  Coverage        ?   58.49%           
=======================================
  Files           ?       12           
  Lines           ?      212           
  Branches        ?        0           
=======================================
  Hits            ?      124           
  Misses          ?       88           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5323b8d...6e5a52a. Read the comment docs.

@sanfrancrisko sanfrancrisko changed the title Non ascii fixes Replace some occurrences of non-ASCII chars Sep 29, 2020
Copy link
Contributor

@sanfrancrisko sanfrancrisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix up @DLeich

@sanfrancrisko sanfrancrisko merged commit c610f78 into puppetlabs:main Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants