(MAINT) Fix acceptance tests #1488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelnak
force-pushed
the
maint-acceptance_tests
branch
28 times, most recently
from
10e5609 to
5487d79
Compare
chelnak
force-pushed
the
maint-acceptance_tests
branch
6 times, most recently
from
15f9285 to
d5eab48
Compare
Prior to this commit `matrix_from_metadata_v2` was removed and replaced with a manually built matrix. This commit restores the use of `matrix_from_metadata_v2`
Prior to this commit acceptance tests for SLES 15 were failing. This was caused by a charset mismatch. This commit fixes the issue by extending the `fetch_charset` method so that it returns `utf8mb3` when the current OS is SLES 15.
chelnak
force-pushed
the
maint-acceptance_tests
branch
from
d5eab48 to
30e085f
Compare
Prior to this commit, xtrabackup acceptance tests would fail when the OS was RHEL 9. This is because xtrabackup is not currently supported for RHEL 9. This commit moves the xtrabackup acceptance tests in to their own spec file and adds conditions to the tests that ensure they are only executed on supported OSes.
This commit removes the `export_locales` method along with it's references. This commit also removes the spec test associated with locales from `00_mysql_server_spec.rb`
Prior to this commit on certian OSes the mysqld apparmor profile present on the github runner would prevent the mysql service from properly starting inside our litmusimage container. The follow OSes were impacted for both puppet 6 & 7 runs: * debian 9 * debian 10 * ubuntu 20.04 This commit adds a new step to the `pr_test` and `nightly` workflows that disables the mysqld apparmor profile if the current provisioner is `provision::docker`. While this fixes the issue, it does make me wonder if this is the right approach.
chelnak
force-pushed
the
maint-acceptance_tests
branch
from
30e085f to
352f6fc
Compare
GSPatton
reviewed
Aug 24, 2022
GSPatton
approved these changes
Aug 24, 2022
LukasAud
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains various fixes for acceptance tests.
Debian / Ubuntu
RHEL 9
SLES 15
This PR also:
matrix_from_metadata_v2in workflowsexport_localesmethod along with references and tests because it is no longer needed.