Skip to content

Readme changes for SUP-2380 #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2021
Merged

Readme changes for SUP-2380 #52

merged 3 commits into from
Apr 28, 2021

Conversation

jordi-garcia
Copy link
Contributor

No description provided.

@jordi-garcia jordi-garcia requested a review from a team as a code owner April 28, 2021 08:41
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

elainemccloskey
elainemccloskey suggested changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@elainemccloskey elainemccloskey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"link" needs replaced with the actual link, last link in the text block needs whitespace removed

elainemccloskey
elainemccloskey suggested changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@elainemccloskey elainemccloskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"link" needs changed to hyperlink to "https://github.com/puppetlabs/puppetlabs-pe_databases/issues"

elainemccloskey
elainemccloskey approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@elainemccloskey elainemccloskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@elainemccloskey elainemccloskey merged commit 9d97888 into puppetlabs:main Apr 28, 2021
@jordi-garcia jordi-garcia deleted the SUP-2380 branch April 28, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@elainemccloskey elainemccloskey elainemccloskey approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jordi-garcia @CLAassistant @elainemccloskey @MartyEwings